From 095cdcd37476cd1bdf9e7c0cecbf818568af829b Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Thu, 24 Sep 2020 11:50:57 +0100 Subject: [PATCH] Revert "[effects/slidingpopups] Start the animation on only windowAdded or windowClosed" This reverts commit 9d4c8fda0989a66d4eb8c876d16fc344815816a9. Unlike other effects this wasn't using hide/show as a hack for not having a created/destroyed signal but because the window is internally hidden when it's in auto-hide mode despite being still mapped. BUG: 426686 --- effects/slidingpopups/slidingpopups.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/effects/slidingpopups/slidingpopups.cpp b/effects/slidingpopups/slidingpopups.cpp index 45e28a84e8..d82f00ca90 100644 --- a/effects/slidingpopups/slidingpopups.cpp +++ b/effects/slidingpopups/slidingpopups.cpp @@ -41,6 +41,8 @@ SlidingPopupsEffect::SlidingPopupsEffect() connect(effects, &EffectsHandler::windowClosed, this, &SlidingPopupsEffect::slideOut); connect(effects, &EffectsHandler::windowDeleted, this, &SlidingPopupsEffect::slotWindowDeleted); connect(effects, &EffectsHandler::propertyNotify, this, &SlidingPopupsEffect::slotPropertyNotify); + connect(effects, &EffectsHandler::windowShown, this, &SlidingPopupsEffect::slideIn); + connect(effects, &EffectsHandler::windowHidden, this, &SlidingPopupsEffect::slideOut); connect(effects, &EffectsHandler::xcbConnectionChanged, this, [this] { m_atom = effects->announceSupportProperty(QByteArrayLiteral("_KDE_SLIDE"), this);