From 09a547361ab3808273250867c58c0f6547789ded Mon Sep 17 00:00:00 2001 From: Yifan Zhu Date: Tue, 19 Dec 2023 19:30:42 -0800 Subject: [PATCH] plugins/overview: Use correct type to match The overview effect uses the type of the dragged object to determine if a single window is dragged or the entires desktop. Commit 0ff4f84a changed the type of mainBackground, but did not update the code for matching the type. BUG: 478746 FIXED-IN: 6.0 --- src/plugins/overview/qml/main.qml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/overview/qml/main.qml b/src/plugins/overview/qml/main.qml index 94241712dd..3e96601c93 100644 --- a/src/plugins/overview/qml/main.qml +++ b/src/plugins/overview/qml/main.qml @@ -409,6 +409,7 @@ FocusScope { property Item currentHeap property Item currentBackgroundItem + // Later we use its type to check whether the user is dragging a desktop or a window Item { id: mainBackground @@ -540,7 +541,7 @@ FocusScope { } onDropped: (drop) => { drop.accepted = true; - if (drag.source instanceof Kirigami.ShadowedRectangle) { + if (drag.source instanceof Item) { // dragging a desktop as a whole if (drag.source === mainBackground) { drop.action = Qt.IgnoreAction;