yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[autotests] Improve stability of testWaylandSurface

Browse source 
* uses an EventQueue
* better waits for events when testing for buffer released
This commit is contained in:
Martin Gräßlin 2015-05-12 15:51:15 +02:00
parent 681211ca33
commit 09bfc4ac5e
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/wayland/autotests/client/test_wayland_surface.cpp
View file

@ -23,6 +23,7 @@ License along with this library. If not, see <http://www.gnu.org/licenses/>.
// KWin // KWin
#include "../../src/client/compositor.h" #include "../../src/client/compositor.h"
#include "../../src/client/connection_thread.h" #include "../../src/client/connection_thread.h"
#include "../../src/client/event_queue.h"
#include "../../src/client/surface.h" #include "../../src/client/surface.h"
#include "../../src/client/region.h" #include "../../src/client/region.h"
#include "../../src/client/registry.h" #include "../../src/client/registry.h"
@ -58,6 +59,7 @@ private:
KWayland::Client::ConnectionThread *m_connection; KWayland::Client::ConnectionThread *m_connection;
KWayland::Client::Compositor *m_compositor; KWayland::Client::Compositor *m_compositor;
KWayland::Client::ShmPool *m_shm; KWayland::Client::ShmPool *m_shm;
KWayland::Client::EventQueue *m_queue;
QThread *m_thread; QThread *m_thread;
}; };
@ -97,18 +99,24 @@ void TestWaylandSurface::init()
m_connection->moveToThread(m_thread); m_connection->moveToThread(m_thread);
m_thread->start(); m_thread->start();
connect(QCoreApplication::eventDispatcher(), &QAbstractEventDispatcher::aboutToBlock, m_connection, /*connect(QCoreApplication::eventDispatcher(), &QAbstractEventDispatcher::aboutToBlock, m_connection,
[this]() { [this]() {
if (m_connection->display()) { if (m_connection->display()) {
wl_display_flush(m_connection->display()); wl_display_flush(m_connection->display());
} }
} }
); );*/
m_connection->initConnection(); m_connection->initConnection();
QVERIFY(connectedSpy.wait()); QVERIFY(connectedSpy.wait());
m_queue = new KWayland::Client::EventQueue(this);
QVERIFY(!m_queue->isValid());
m_queue->setup(m_connection);
QVERIFY(m_queue->isValid());
KWayland::Client::Registry registry; KWayland::Client::Registry registry;
registry.setEventQueue(m_queue);
QSignalSpy compositorSpy(&registry, SIGNAL(compositorAnnounced(quint32,quint32))); QSignalSpy compositorSpy(&registry, SIGNAL(compositorAnnounced(quint32,quint32)));
QSignalSpy shmSpy(&registry, SIGNAL(shmAnnounced(quint32,quint32))); QSignalSpy shmSpy(&registry, SIGNAL(shmAnnounced(quint32,quint32)));
QSignalSpy allAnnounced(&registry, SIGNAL(interfacesAnnounced())); QSignalSpy allAnnounced(&registry, SIGNAL(interfacesAnnounced()));
@ -137,6 +145,10 @@ void TestWaylandSurface::cleanup()
delete m_shm; delete m_shm;
m_shm = nullptr; m_shm = nullptr;
} }
if (m_queue) {
delete m_queue;
m_queue = nullptr;
}
if (m_thread) { if (m_thread) {
m_thread->quit(); m_thread->quit();
m_thread->wait(); m_thread->wait();
@ -359,6 +371,9 @@ void TestWaylandSurface::testAttachBuffer()
delete buffer2; delete buffer2;
// TODO: we should have a signal on when the Buffer gets released // TODO: we should have a signal on when the Buffer gets released
QCoreApplication::processEvents(QEventLoop::WaitForMoreEvents); QCoreApplication::processEvents(QEventLoop::WaitForMoreEvents);
if (!redBuffer.data()->isReleased()) {
QCoreApplication::processEvents(QEventLoop::WaitForMoreEvents);
}
QVERIFY(redBuffer.data()->isReleased()); QVERIFY(redBuffer.data()->isReleased());
KWayland::Server::BufferInterface *buffer3 = serverSurface->buffer(); KWayland::Server::BufferInterface *buffer3 = serverSurface->buffer();
@ -624,6 +639,7 @@ void TestWaylandSurface::testDestroy()
connect(m_connection, &ConnectionThread::connectionDied, s, &Surface::destroy); connect(m_connection, &ConnectionThread::connectionDied, s, &Surface::destroy);
connect(m_connection, &ConnectionThread::connectionDied, m_compositor, &Compositor::destroy); connect(m_connection, &ConnectionThread::connectionDied, m_compositor, &Compositor::destroy);
connect(m_connection, &ConnectionThread::connectionDied, m_shm, &ShmPool::destroy); connect(m_connection, &ConnectionThread::connectionDied, m_shm, &ShmPool::destroy);
connect(m_connection, &ConnectionThread::connectionDied, m_queue, &EventQueue::destroy);
QVERIFY(s->isValid()); QVERIFY(s->isValid());
QSignalSpy connectionDiedSpy(m_connection, SIGNAL(connectionDied())); QSignalSpy connectionDiedSpy(m_connection, SIGNAL(connectionDied()));