yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: fix offset cursor

Browse source 
For some reason with legacy the cursor gets an offset when changing the
image. In order to work around this, directly issue a cursor move with the
corrected position when changing the buffer
This commit is contained in:
Xaver Hugl 2022-05-18 17:39:21 +02:00 committed by Vlad Zahorodnii
parent 8f009c2db1
commit 0bbd4445f2
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/backends/drm/drm_pipeline_legacy.cpp
View file

@ -127,14 +127,19 @@ bool DrmPipeline::setCursorLegacy()
{
const auto bo = cursorLayer()->currentBuffer();
const uint32_t handle = bo && bo->buffer() && cursorLayer()->isVisible() ? bo->buffer()->handles()[0] : 0;
const QSize s = gpu()->cursorSize();
int ret = drmModeSetCursor2(gpu()->fd(), m_pending.crtc->id(), handle, s.width(), s.height(),
m_pending.cursorHotspot.x(), m_pending.cursorHotspot.y());
if (ret == -ENOTSUP) {
// for NVIDIA case that does not support drmModeSetCursor2
ret = drmModeSetCursor(gpu()->fd(), m_pending.crtc->id(), handle, s.width(), s.height());
}
return ret == 0;
struct drm_mode_cursor2 arg = {
.flags = DRM_MODE_CURSOR_BO | DRM_MODE_CURSOR_MOVE,
.crtc_id = m_pending.crtc->id(),
.x = m_pending.cursorLayer->position().x(),
.y = m_pending.cursorLayer->position().y(),
.width = (uint32_t)gpu()->cursorSize().width(),
.height = (uint32_t)gpu()->cursorSize().height(),
.handle = handle,
.hot_x = m_pending.cursorHotspot.x(),
.hot_y = m_pending.cursorHotspot.y(),
};
return drmIoctl(gpu()->fd(), DRM_IOCTL_MODE_CURSOR2, &arg) == 0;
}
bool DrmPipeline::moveCursorLegacy()