From 158f1db51313d39c0cb3080c1af6aad05572fcd4 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Mon, 14 Feb 2022 21:34:50 +0200 Subject: [PATCH] autotests: Drop TestXdgShellClient::testWindowOpensLargerThanScreen() With the xdg_toplevel.configure_bounds support, the compositor is finally able to tell the client the maximum recommended window size. That approach allows us to keep the compositor side simple and it prevents (as long as the app is well behaved) annoying visual glitches such as mapping window with one size and then quickly resizing it to the final size. --- autotests/integration/xdgshellclient_test.cpp | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/autotests/integration/xdgshellclient_test.cpp b/autotests/integration/xdgshellclient_test.cpp index 5d982d02c4..5ff45e8c1a 100644 --- a/autotests/integration/xdgshellclient_test.cpp +++ b/autotests/integration/xdgshellclient_test.cpp @@ -75,7 +75,6 @@ private Q_SLOTS: void testMaximizedToFullscreen_data(); void testMaximizedToFullscreen(); void testFullscreenMultipleOutputs(); - void testWindowOpensLargerThanScreen(); void testHidden(); void testDesktopFileName(); void testCaptionSimplified(); @@ -618,35 +617,6 @@ void TestXdgShellClient::testFullscreenMultipleOutputs() } } -void TestXdgShellClient::testWindowOpensLargerThanScreen() -{ - // this test creates a window which is as large as the screen, but is decorated - // the window should get resized to fit into the screen, BUG: 366632 - - QScopedPointer surface(Test::createSurface()); - QScopedPointer shellSurface(Test::createXdgToplevelSurface(surface.data(), Test::CreationSetup::CreateOnly)); - QScopedPointer decoration(Test::createXdgToplevelDecorationV1(shellSurface.data())); - QSignalSpy decorationConfigureRequestedSpy(decoration.data(), &Test::XdgToplevelDecorationV1::configureRequested); - QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested); - QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested); - - // Initialize the xdg-toplevel surface. - decoration->set_mode(Test::XdgToplevelDecorationV1::mode_server_side); - surface->commit(KWayland::Client::Surface::CommitFlag::None); - - QVERIFY(surfaceConfigureRequestedSpy.wait()); - QCOMPARE(decorationConfigureRequestedSpy.last().at(0).value(), Test::XdgToplevelDecorationV1::mode_server_side); - - shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value()); - AbstractOutput *output = workspace()->activeOutput(); - auto c = Test::renderAndWaitForShown(surface.data(), output->geometry().size(), Qt::blue); - QVERIFY(c); - QVERIFY(c->isActive()); - QVERIFY(c->isDecorated()); - QEXPECT_FAIL("", "BUG 366632", Continue); - QCOMPARE(c->frameGeometry(), QRect(QPoint(0, 0), output->geometry().size())); -} - void TestXdgShellClient::testHidden() { // this test verifies that when hiding window it doesn't get shown