From 1747e497e4a23c2f0524455a7e608c64b017bbd7 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Fri, 6 Dec 2019 11:01:08 +0200 Subject: [PATCH] [effects/fallapart] Override scale, fade, and glide effect Summary: Currently the fall apart effect doesn't work in conjuction with window open/close animation effects, e.g. scale. The reason for that is those effects grab windows before the fall apart effect. Test Plan: * Enable the fall apart effect and the scale effect; * Close a window. (without this patch the window doesn't fall apart) Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: ngraham, davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19723 --- effects/fallapart/fallapart.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/effects/fallapart/fallapart.cpp b/effects/fallapart/fallapart.cpp index df623fb836..5e08fd971d 100644 --- a/effects/fallapart/fallapart.cpp +++ b/effects/fallapart/fallapart.cpp @@ -163,9 +163,6 @@ void FallApartEffect::slotWindowClosed(EffectWindow* c) return; if (!c->isVisible()) return; - const void* e = c->data(WindowClosedGrabRole).value(); - if (e && e != this) - return; c->setData(WindowClosedGrabRole, QVariant::fromValue(static_cast(this))); windows[ c ] = 0; c->refWindow();