yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[wayland] Correctly initialise m_requestedClientSize

Browse source 
QSize default constructor does not set width/height to 0,0 but instead
to an invalid size -1,-1. This went unnoticed as Qt5.12 corrected these
values to the intended 0,0.

Reviewed By: Roman Gilg
This commit is contained in:
David Edmundson 2018-10-11 22:58:16 +01:00
parent 8971af19e3
commit 17d4cbe125
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell_client.cpp
View file

@ -1184,7 +1184,7 @@ void ShellClient::requestGeometry(const QRect &rect)
configureRequest.maximizeMode = m_requestedMaximizeMode;
const QSize size = rect.size() - QSize(borderLeft() + borderRight(), borderTop() + borderBottom());
m_requestedClientSize = size;
m_requestedClientSize = QSize(0, 0);
if (m_shellSurface) {
m_shellSurface->requestSize(size);

2
shell_client.h
View file

@ -220,7 +220,7 @@ private:
QSize m_clientSize;
// last size we requested or empty if we haven't sent an explicit request to the client
// if empty the client should choose their own default size
QSize m_requestedClientSize;
QSize m_requestedClientSize = QSize(0, 0);
struct PendingConfigureRequest {
//note for wl_shell we have no serial, so serialId and m_lastAckedConfigureRequest will always be 0