From 1a9a49ab7a44ca354cd79409c90878b26706a042 Mon Sep 17 00:00:00 2001 From: Marco Martin Date: Wed, 9 Oct 2019 13:56:55 +0200 Subject: [PATCH] don't allow to resize or move fullscreen windows Summary: add the same check of the Client class: if a window is fullscreen, is not movable nor resizable Test Plan: Doesn't have any visible regression over normal usage, this partially tackles a bug that can be seen in plasma mobile: if the placement is "maximizing", then asking windows to be shown as fullscreen has no effect and they will always be shown as a normal maximized window. this now doesn't happen anymore.. most of the times, as there must be some race condition as a concause of the problem Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24515 --- xdgshellclient.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xdgshellclient.cpp b/xdgshellclient.cpp index 76106093bb..eaf5e4a091 100644 --- a/xdgshellclient.cpp +++ b/xdgshellclient.cpp @@ -634,6 +634,9 @@ bool XdgShellClient::isMinimizable() const bool XdgShellClient::isMovable() const { + if (isFullScreen()) { + return false; + } if (rules()->checkPosition(invalidPoint) != invalidPoint) { return false; } @@ -662,6 +665,9 @@ bool XdgShellClient::isMovableAcrossScreens() const bool XdgShellClient::isResizable() const { + if (isFullScreen()) { + return false; + } if (rules()->checkSize(QSize()).isValid()) { return false; }