From 1d5b3a3c893fee9d5070024098780d611ca59bfc Mon Sep 17 00:00:00 2001
From: Ismael Asensio <isma.af@gmail.com>
Date: Mon, 5 Dec 2022 23:09:51 +0100
Subject: [PATCH] kcms/rules: Set a title for error messages

---
 src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml | 7 ++++---
 src/kcmkwin/kwinrules/rulesmodel.cpp                      | 3 ++-
 src/kcmkwin/kwinrules/rulesmodel.h                        | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml b/src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
index 314a217b6a..074236c58a 100644
--- a/src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
+++ b/src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
@@ -135,8 +135,9 @@ ScrollViewKCM {
             overlayModel.onlySuggestions = true;
             propertySheet.sheetOpen = true;
         }
-        function onShowErrorMessage(message) {
-            errorLabel.text = message
+        function onShowErrorMessage(title, message) {
+            errorSheet.title = title
+            errorSheet.message = message
             errorSheet.open()
         }
     }
@@ -144,7 +145,7 @@ ScrollViewKCM {
     Kirigami.OverlaySheet {
         id: errorSheet
 
-        title: i18n("Error")
+        property alias message: errorLabel.text
 
         Kirigami.Heading {
             id: errorLabel
diff --git a/src/kcmkwin/kwinrules/rulesmodel.cpp b/src/kcmkwin/kwinrules/rulesmodel.cpp
index d59f7c3858..78894fa665 100644
--- a/src/kcmkwin/kwinrules/rulesmodel.cpp
+++ b/src/kcmkwin/kwinrules/rulesmodel.cpp
@@ -851,7 +851,8 @@ void RulesModel::selectX11Window()
         self->deleteLater();
         if (!reply.isValid()) {
             if (reply.error().name() == QLatin1String("org.kde.KWin.Error.InvalidWindow")) {
-                Q_EMIT showErrorMessage(i18n("Could not detect window properties. The window is not managed by KWin."));
+                Q_EMIT showErrorMessage(i18n("Unmanaged window"),
+                                        i18n("Could not detect window properties. The window is not managed by KWin."));
             }
             return;
         }
diff --git a/src/kcmkwin/kwinrules/rulesmodel.h b/src/kcmkwin/kwinrules/rulesmodel.h
index cfd865c955..0434286d65 100644
--- a/src/kcmkwin/kwinrules/rulesmodel.h
+++ b/src/kcmkwin/kwinrules/rulesmodel.h
@@ -78,7 +78,7 @@ Q_SIGNALS:
     void warningMessagesChanged();
 
     void showSuggestions();
-    void showErrorMessage(const QString &message);
+    void showErrorMessage(const QString &title, const QString &message);
 
     void virtualDesktopsUpdated();