From 1d9653953b9d4a1240e978e7355695fcf98de8b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Mon, 23 May 2016 08:54:28 +0200 Subject: [PATCH] Destroy ShellClient when the SurfaceInterface gets destroyed KWayland was changed: the ShellSurfaceInterface does no longer get destroyed when the parent SurfaceInterface gets destroyed. For the wl_shell_surface there is no dtor request in the interface so the resource sticks around and also the ShellClient is kept. This change ensures that the ShellClient also gets destroyed when the Surface is destroyed. This should fix some broken tests. --- shell_client.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/shell_client.cpp b/shell_client.cpp index c4cf5ddb46..bc164e2a62 100644 --- a/shell_client.cpp +++ b/shell_client.cpp @@ -97,6 +97,7 @@ void ShellClient::init() } ); connect(s, &SurfaceInterface::unmapped, this, &ShellClient::unmap); + connect(s, &SurfaceInterface::destroyed, this, &ShellClient::destroyClient); if (m_shellSurface) { connect(m_shellSurface, &ShellSurfaceInterface::destroyed, this, &ShellClient::destroyClient); connect(m_shellSurface, &ShellSurfaceInterface::titleChanged, this, &ShellClient::captionChanged);