yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: fix format sorting

Browse source 
As the drm format number of 10 bit colors is lower, the fallback sorting
preferred those formats, even if KWIN_DRM_PREFER_COLOR_DEPTH=24 was set.
To fix that, prefer 8 bit colors over something random.
This commit is contained in:
Xaver Hugl 2022-10-26 19:18:37 +02:00
parent 8fa1883cd9
commit 1dcbc3c6f8
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/backends/drm/drm_egl_layer_surface.cpp
View file

@ -225,10 +225,13 @@ bool EglGbmLayerSurface::createGbmSurface(const QSize &size, const QMap<uint32_t
return lhs.alphaSize > rhs.alphaSize;
} else if (m_eglBackend->prefer10bpc() && ((lhs.bpp == 30) != (rhs.bpp == 30))) {
// prefer 10bpc / 30bpp formats
return lhs.bpp == 30 ? true : false;
return lhs.bpp == 30;
} else if ((lhs.bpp == 24) != (rhs.bpp == 24)) {
// prefer 8bpc / 24bpp formats over something we don't ask for
return lhs.bpp == 24;
} else {
// fallback
return lhs.drmFormat < rhs.drmFormat;
// fallback: prefer higher bpp
return lhs.bpp > rhs.bpp;
}
});
for (const auto &format : qAsConst(sortedFormats)) {