From 1fada99478a807e23f4887c590a0516e027851a2 Mon Sep 17 00:00:00 2001 From: Roman Gilg Date: Sun, 2 Sep 2018 23:01:48 +0200 Subject: [PATCH] Activate clients on drag enter Summary: We currently only raise a client when a drag enters it and not activate it. This is confusing since afterwards the raised window has not keyboard focus although visually being in front of the window the drag originated from. Therefore activate entered windows instead of only raising them. Test Plan: Manually and autotests still pass. Reviewers: #kwin, hein Reviewed By: hein Subscribers: anthonyfieroni, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15225 --- input.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/input.cpp b/input.cpp index d1b3ecbd04..328c173c88 100644 --- a/input.cpp +++ b/input.cpp @@ -1512,7 +1512,7 @@ public: // TODO: consider decorations if (t->surface() != seat->dragSurface()) { if (AbstractClient *c = qobject_cast(t)) { - workspace()->raiseClient(c); + workspace()->activateClient(c); } seat->setPointerPos(event->globalPos()); seat->setDragTarget(t->surface(), event->globalPos(), t->inputTransformation());