From 1fef4760bf1d3b9446713a6d55d0fc0119b8d1d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivan=20=C4=8Cuki=C4=87?= Date: Fri, 8 Apr 2016 09:26:43 +0200 Subject: [PATCH] Testing whether m_lastCreatedSettings is not null before calling its method Summary: It looks like something was forgotten here - there is a completely empty body for an if statement that checks whether the pointer is null. So this might not be the desired way to fix this. Should m_lastCreatedSettings be instantiated instead? Reviewers: graesslin Reviewed By: graesslin Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1348 --- kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp b/kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp index 7d201f31d4..7a74077280 100644 --- a/kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp +++ b/kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp @@ -199,9 +199,9 @@ void PreviewBridge::configure() auto save = [this,kcm] { kcm->save(); - if (!m_lastCreatedSettings) { + if (m_lastCreatedSettings) { + emit m_lastCreatedSettings->decorationSettings()->reconfigured(); } - emit m_lastCreatedSettings->decorationSettings()->reconfigured(); // Send signal to all kwin instances QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KWin"), QStringLiteral("org.kde.KWin"),