From 205fb923cb8e1cbc0d26edc5a2ce37784ac32b41 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Thu, 26 Aug 2021 09:10:25 -0600 Subject: [PATCH] [effects/overview] Speed up animation The current duration is 300ms, which is inappropriate for two reasons: 1. It's too slow 2. It doesn't match one of the standard durations. The effect should ideally use those durations directly, but if this is not possible for technical reasons, it should use the effective value of one of those durations. Units.longDuration is 200ms which is the most appropriate one to use here. Therefore, change the animation duration from 300ms to 200ms to match the standard Units.longDuration duration. BUG: 441308 FIXED-IN: 5.23 --- src/effects/overview/overvieweffect.cpp | 2 +- src/effects/overview/overvieweffect.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/effects/overview/overvieweffect.cpp b/src/effects/overview/overvieweffect.cpp index 8f0a54bbf7..8a8451e57a 100644 --- a/src/effects/overview/overvieweffect.cpp +++ b/src/effects/overview/overvieweffect.cpp @@ -105,7 +105,7 @@ void OverviewEffect::reconfigure(ReconfigureFlags) { OverviewConfig::self()->read(); setLayout(ExpoLayout::LayoutMode(OverviewConfig::layoutMode())); - setAnimationDuration(animationTime(300)); + setAnimationDuration(animationTime(200)); for (const ElectricBorder &border : qAsConst(m_borderActivate)) { effects->unreserveElectricBorder(border, this); diff --git a/src/effects/overview/overvieweffect.h b/src/effects/overview/overvieweffect.h index 782f887617..3d89994492 100644 --- a/src/effects/overview/overvieweffect.h +++ b/src/effects/overview/overvieweffect.h @@ -87,7 +87,7 @@ private: QList m_borderActivate; QList m_touchBorderActivate; bool m_activated = false; - int m_animationDuration = 300; + int m_animationDuration = 200; ExpoLayout::LayoutMode m_layout = ExpoLayout::LayoutNatural; };