yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins/screenshot: Port blitScreenshot() to glReadnPixels()

Browse source 
With glReadnPixels(), it can be guaranteed that the texture data won't
be written beyond the QImage buffer bounds.
This commit is contained in:
Vlad Zahorodnii 2024-07-08 19:34:48 +03:00
parent d2df8ea9aa
commit 230e456ffd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/plugins/screenshot/screenshot.cpp
View file

@ -369,7 +369,7 @@ QImage ScreenShotEffect::blitScreenshot(const RenderTarget &renderTarget, const
{
QImage image;
if (effects->isOpenGLCompositing()) {
if (OpenGlContext *context = effects->openglContext()) {
const auto screenGeometry = m_paintedScreen ? m_paintedScreen->geometry() : effects->virtualScreenGeometry();
const QSize nativeSize = renderTarget.transform().map(
snapToPixelGrid(scaledRect(geometry, devicePixelRatio))
@ -397,8 +397,8 @@ QImage ScreenShotEffect::blitScreenshot(const RenderTarget &renderTarget, const
target.blitFromFramebuffer(viewport.mapToRenderTarget(geometry));
GLFramebuffer::pushFramebuffer(&target);
}
glReadPixels(0, 0, nativeSize.width(), nativeSize.height(), GL_RGBA,
GL_UNSIGNED_BYTE, static_cast<GLvoid *>(image.bits()));
context->glReadnPixels(0, 0, nativeSize.width(), nativeSize.height(), GL_RGBA,
GL_UNSIGNED_BYTE, image.sizeInBytes(), image.bits());
GLFramebuffer::popFramebuffer();
convertFromGLImage(image, nativeSize.width(), nativeSize.height(), renderTarget.transform());
}