yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[wayland] Recursively destroy WindowPixmap objects

Browse source 
Summary:
We need to destroy the root WindowPixmap together with all of its
children; otherwise, buffers that are attached to subsurfaces will
not be released.

Test Plan:
weston-subsurfaces doesn't quit with an error message saying that
all buffers are held by the compositor.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D28145
This commit is contained in:
Vlad Zahorodnii 2020-03-19 19:25:55 +02:00
parent 348e72c56e
commit 25276d3058
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scene.cpp
View file

@ -1040,6 +1040,8 @@ WindowPixmap::WindowPixmap(const QPointer<KWayland::Server::SubSurfaceInterface>
WindowPixmap::~WindowPixmap() WindowPixmap::~WindowPixmap()
{ {
qDeleteAll(m_children);
if (m_pixmap != XCB_WINDOW_NONE) { if (m_pixmap != XCB_WINDOW_NONE) {
xcb_free_pixmap(connection(), m_pixmap); xcb_free_pixmap(connection(), m_pixmap);
} }