From 260d6e7a22a881dd9afe000b6a30b32e867ceef0 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Mon, 21 Sep 2020 15:00:58 +0300 Subject: [PATCH] Keep unreferenced buffers around One problem with delaying destruction of buffer objects is that the compositor may create a shadow that references defunct buffers. One way to fix that issue is to immediately destroy buffers. However, there is other way to address the issue - keep released buffers alive. If a buffer is kept alive by the client, then it will most likely be used again. It also simplifies buffer management. BUG: 425233 --- src/wayland/server/buffer_interface.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/wayland/server/buffer_interface.cpp b/src/wayland/server/buffer_interface.cpp index 1e82e2fcec..2e0ad66fe7 100644 --- a/src/wayland/server/buffer_interface.cpp +++ b/src/wayland/server/buffer_interface.cpp @@ -240,7 +240,6 @@ void BufferInterface::unref() wl_buffer_send_release(d->buffer); wl_client_flush(wl_resource_get_client(d->buffer)); } - deleteLater(); } }