From 2635243650f88322e5bfd124859cdc622c619fc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Tue, 11 Aug 2015 08:45:57 +0200 Subject: [PATCH] Drop build option KWIN_PLASMA_ACTIVE The build option wasn't used for 5.x at all and in this way doesn't make any sense nowadays. We want to have a converged desktop which also means that the window manager should be able to switch to a different form factor with a full feature set (plug in external screen to smartphone and it should be full desktop). A trimmed down KWin with compiled out functionality cannot do that. Also the need for trimmed down KWin becomes less and less important given the improved hardware we target nowadays. This change got triggered by the announcement to close down the Plasma Active mailinglist [1], which shows that having a build option called Plasma Active is no longer needed. [1] http://permalink.gmane.org/gmane.comp.kde.devel.active/4343 REVIEW: 124694 --- CMakeLists.txt | 9 --------- 1 file changed, 9 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 056801feaa..ec9e3d3f59 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -222,7 +222,6 @@ option(KWIN_BUILD_KCMS "Enable building of KWin configuration modules." ON) option(KWIN_BUILD_TABBOX "Enable building of KWin Tabbox functionality" ON) option(KWIN_BUILD_XRENDER_COMPOSITING "Enable building of KWin with XRender Compositing support" ON) cmake_dependent_option(KWIN_BUILD_ACTIVITIES "Enable building of KWin with kactivities support" ON "KF5Activities_FOUND" OFF) -option(KWIN_PLASMA_ACTIVE "Enable building KWin for Plasma Active." OFF) option(KWIN_BUILD_COVERAGE "Build KWin with gcov support" OFF) @@ -237,14 +236,6 @@ set(KWIN_INTERNAL_NAME_X11 "kwin_x11") set(KWIN_INTERNAL_NAME_WAYLAND "kwin_wayland") set(KWIN_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) -if(KWIN_PLASMA_ACTIVE) - set(KWIN_BUILD_DECORATIONS OFF) - set(KWIN_BUILD_KCMS OFF) - set(KWIN_BUILD_XRENDER_COMPOSITING OFF) - set(KWIN_BUILD_WITH_OPENGLES ON) - set(KWIN_NAME "kwinactive") -endif() - set(KWIN_BUILD_OPENGL FALSE) set(KWIN_BUILD_OPENGLES FALSE) if(${Qt5Gui_OPENGL_IMPLEMENTATION} STREQUAL "GL")