From 273a3fabd0ee7aa1321c4636dc29e4c9b29fa5f1 Mon Sep 17 00:00:00 2001
From: David Edmundson <kde@davidedmundson.co.uk>
Date: Wed, 10 Oct 2018 14:54:16 +0100
Subject: [PATCH] [activities] Fix logic error in user menu blocking activity
 updates

Summary:
There's an attempt to block updates to activities whilst the popup menu
is showing.

In one of the two code paths for positioning the menu the block is set
but instead of releasing the block at the end of the exec locks it
again.

CCBUG: 335725

Test Plan:
On X11 changed activities with the popup menu near the bottom.
It still flickered like crazy whilst the menu is open (see bug report)
But now at least fixes itself after

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16101
---
 useractions.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/useractions.cpp b/useractions.cpp
index f3ca0f90bf..1d10f7a228 100644
--- a/useractions.cpp
+++ b/useractions.cpp
@@ -178,7 +178,7 @@ void UserActionsMenu::show(const QRect &pos, const QWeakPointer<AbstractClient>
             }
         }
         if (!m_client.isNull())
-            m_client.data()->blockActivityUpdates(true);
+            m_client.data()->blockActivityUpdates(false);
     }
 }