yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

window: don't use exact comparison for QRectFs

Browse source 
With fractional geometries, we can only guarantee that
nextMoveResizeGeom eventually is within one unit of
currentMoveResizeGeom.

BUG: 479786
FIXED-IN: 6.0
This commit is contained in:
Yifan Zhu 2024-01-15 22:54:19 -08:00
parent e963ae09cc
commit 2dba3d30af
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/window.cpp
View file

@ -1736,7 +1736,11 @@ void Window::handleInteractiveMoveResize(qreal x, qreal y, qreal x_root, qreal y
currentTry.translate(dx, dy);
nextMoveResizeGeom = currentTry;
if (nextMoveResizeGeom == currentMoveResizeGeom) {
// sinces nextMoveResizeGeom is fractional, at best it is within 1 unit of currentMoveResizeGeom
if (std::abs(currentMoveResizeGeom.left() - nextMoveResizeGeom.left()) <= 1.0
&& std::abs(currentMoveResizeGeom.right() - nextMoveResizeGeom.right()) <= 1.0
&& std::abs(currentMoveResizeGeom.top() - nextMoveResizeGeom.top()) <= 1.0
&& std::abs(currentMoveResizeGeom.bottom() - nextMoveResizeGeom.bottom()) <= 1.0) {
break; // Prevent lockup
}
}