yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: Fix surface and buffer damage order in qpainter output layers

Browse source 
The prototype of OutputLayer::endFrame() looks as follows

    virtual bool endFrame(const QRegion &renderedRegion, const QRegion &damagedRegion) = 0;

On the other hand, qpainter output layers use a different order in the
header file and the cpp file.
This commit is contained in:
Vlad Zahorodnii 2023-01-11 11:13:46 +02:00
parent 91bef430bf
commit 301e57169d
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backends/drm/drm_qpainter_layer.cpp
View file

@ -111,7 +111,7 @@ std::optional<OutputLayerBeginFrameInfo> DrmCursorQPainterLayer::beginFrame()
};
}
bool DrmCursorQPainterLayer::endFrame(const QRegion &damagedRegion, const QRegion &renderedRegion)
bool DrmCursorQPainterLayer::endFrame(const QRegion &renderedRegion, const QRegion &damagedRegion)
{
m_swapchain->releaseBuffer(m_swapchain->currentBuffer(), damagedRegion);
m_currentFramebuffer = DrmFramebuffer::createFramebuffer(m_swapchain->currentBuffer());

6
src/backends/drm/drm_qpainter_layer.h
View file

@ -27,7 +27,7 @@ public:
DrmQPainterLayer(DrmPipeline *pipeline);
std::optional<OutputLayerBeginFrameInfo> beginFrame() override;
bool endFrame(const QRegion &damagedRegion, const QRegion &renderedRegion) override;
bool endFrame(const QRegion &renderedRegion, const QRegion &damagedRegion) override;
bool checkTestBuffer() override;
std::shared_ptr<DrmFramebuffer> currentBuffer() const override;
QRegion currentDamage() const override;
@ -47,7 +47,7 @@ public:
DrmCursorQPainterLayer(DrmPipeline *pipeline);
std::optional<OutputLayerBeginFrameInfo> beginFrame() override;
bool endFrame(const QRegion &damagedRegion, const QRegion &renderedRegion) override;
bool endFrame(const QRegion &renderedRegion, const QRegion &damagedRegion) override;
bool checkTestBuffer() override;
std::shared_ptr<DrmFramebuffer> currentBuffer() const override;
@ -65,7 +65,7 @@ public:
DrmVirtualQPainterLayer(DrmVirtualOutput *output);
std::optional<OutputLayerBeginFrameInfo> beginFrame() override;
bool endFrame(const QRegion &damagedRegion, const QRegion &renderedRegion) override;
bool endFrame(const QRegion &renderedRegion, const QRegion &damagedRegion) override;
QRegion currentDamage() const override;
void releaseBuffers() override;