From 3041b871ea2cd94997dafcb4c1f72364be655b06 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= <mgraesslin@kde.org>
Date: Mon, 7 Nov 2016 16:03:50 +0100
Subject: [PATCH] [libkwineffects] Delete EffectsHandler::deleteRootProperty

Summary:
The method is not used by any Effect and is X11 specific, thus better
remove it for good.

Reviewers: #kwin, #plasma_on_wayland

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D3298
---
 autotests/mock_effectshandler.h | 1 -
 effects.cpp                     | 5 -----
 effects.h                       | 1 -
 libkwineffects/kwineffects.h    | 1 -
 4 files changed, 8 deletions(-)

diff --git a/autotests/mock_effectshandler.h b/autotests/mock_effectshandler.h
index 8a0179c861..5f9467f70f 100644
--- a/autotests/mock_effectshandler.h
+++ b/autotests/mock_effectshandler.h
@@ -85,7 +85,6 @@ public:
         return false;
     }
     void defineCursor(Qt::CursorShape) override {}
-    void deleteRootProperty(long int) const override {}
     int desktopAbove(int, bool) const override {
         return 0;
     }
diff --git a/effects.cpp b/effects.cpp
index ff73008975..fc4b94abcd 100644
--- a/effects.cpp
+++ b/effects.cpp
@@ -830,11 +830,6 @@ QByteArray EffectsHandlerImpl::readRootProperty(long atom, long type, int format
     return readWindowProperty(rootWindow(), atom, type, format);
 }
 
-void EffectsHandlerImpl::deleteRootProperty(long atom) const
-{
-    deleteWindowProperty(rootWindow(), atom);
-}
-
 void EffectsHandlerImpl::activateWindow(EffectWindow* c)
 {
     if (AbstractClient* cl = dynamic_cast< AbstractClient* >(static_cast<EffectWindowImpl*>(c)->window()))
diff --git a/effects.h b/effects.h
index e6a316c61a..9559fdddab 100644
--- a/effects.h
+++ b/effects.h
@@ -176,7 +176,6 @@ public:
     void reconfigure() override;
     void registerPropertyType(long atom, bool reg) override;
     QByteArray readRootProperty(long atom, long type, int format) const override;
-    void deleteRootProperty(long atom) const override;
     xcb_atom_t announceSupportProperty(const QByteArray& propertyName, Effect* effect) override;
     void removeSupportProperty(const QByteArray& propertyName, Effect* effect) override;
 
diff --git a/libkwineffects/kwineffects.h b/libkwineffects/kwineffects.h
index 077890f4d2..44b49d230e 100644
--- a/libkwineffects/kwineffects.h
+++ b/libkwineffects/kwineffects.h
@@ -1064,7 +1064,6 @@ public:
     */
     virtual void registerPropertyType(long atom, bool reg) = 0;
     virtual QByteArray readRootProperty(long atom, long type, int format) const = 0;
-    virtual void deleteRootProperty(long atom) const = 0;
     /**
      * @brief Announces support for the feature with the given name. If no other Effect
      * has announced support for this feature yet, an X11 property will be installed on