From 34d0df3e0afbe83b7611ff37964e059cb7e9b849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Fri, 5 Apr 2013 08:12:32 +0200 Subject: [PATCH] Remove Workspace::updateOnAllActivitiesOfTransients Method is more or less just a clone of the Virtual Desktop variant and not needed as toggleClientOnActivity already takes care of transients. --- client.cpp | 3 --- group.cpp | 13 ------------- workspace.h | 1 - 3 files changed, 17 deletions(-) diff --git a/client.cpp b/client.cpp index 3aad8cd5db..5f5f703ff8 100644 --- a/client.cpp +++ b/client.cpp @@ -1578,8 +1578,6 @@ void Client::updateActivities(bool includeTransients) } emit activitiesChanged(this); m_blockedActivityUpdatesRequireTransients = false; // reset - if (includeTransients) - workspace()->updateOnAllActivitiesOfTransients(this); FocusChain::self()->update(this, FocusChain::MakeFirst); updateVisibility(); updateWindowRules(Rules::Activity); @@ -1644,7 +1642,6 @@ void Client::setOnAllActivities(bool on) } else { setOnActivity(Workspace::self()->currentActivity(), true); - workspace()->updateOnAllActivitiesOfTransients(this); } } diff --git a/group.cpp b/group.cpp index 902cc50dfb..db7e570fe5 100644 --- a/group.cpp +++ b/group.cpp @@ -418,19 +418,6 @@ void Workspace::updateOnAllDesktopsOfTransients(Client* c) } } -/*! - Sets the client \a c's transient windows' on_all_activities property to \a on_all_desktops. - */ -void Workspace::updateOnAllActivitiesOfTransients(Client* c) -{ - for (ClientList::ConstIterator it = c->transients().constBegin(); - it != c->transients().constEnd(); - ++it) { - if ((*it)->isOnAllActivities() != c->isOnAllActivities()) - (*it)->setOnAllActivities(c->isOnAllActivities()); - } -} - // A new window has been mapped. Check if it's not a mainwindow for some already existing transient window. void Workspace::checkTransients(Window w) { diff --git a/workspace.h b/workspace.h index 685b3ccc9b..8d75b9297e 100644 --- a/workspace.h +++ b/workspace.h @@ -307,7 +307,6 @@ public: void updateMinimizedOfTransients(Client*); void updateOnAllDesktopsOfTransients(Client*); - void updateOnAllActivitiesOfTransients(Client*); void checkTransients(Window w); void performWindowOperation(Client* c, WindowOperation op);