yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

kcms/desktop: Expand button label from "Add" to "Add Desktop"

Browse source 
Also pull "Rows" out of the SpinBox into a dedicated label.

Both to address concerns "Add" about being misinterpreted as
"Add Row", given that the button to add a new virtual desktop
now sits right next to the row count spinner.
This commit is contained in:
Jakob Petsovits 2024-04-14 14:29:10 -04:00
parent e804b45d86
commit 351f613ef4
1 changed files with 24 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
src/kcms/desktop/ui/main.qml
View file

@ -19,36 +19,39 @@ KCM.ScrollViewKCM {
actions: [
Kirigami.Action {
displayComponent: QQC2.SpinBox {
id: rowsSpinBox
displayComponent: RowLayout {
spacing: Kirigami.Units.smallSpacing
from: 1
to: 20
editable: true
value: kcm.desktopsModel.rows
textFromValue: (value, locale) => i18np("1 Row", "%1 Rows", value)
valueFromText: (text, locale) => parseInt(text, 10)
onValueModified: kcm.desktopsModel.rows = value
KCM.SettingHighlighter {
highlight: kcm.desktopsModel.rows !== 2
QQC2.Label {
text: i18nc("@text:label Number of rows, label associated to a number input field", "Rows:")
}
Connections {
target: kcm.desktopsModel
QQC2.SpinBox {
id: rowsSpinBox
function onReadyChanged() {
rowsSpinBox.value = kcm.desktopsModel.rows;
from: 1
to: 20
editable: true
value: kcm.desktopsModel.rows
onValueModified: kcm.desktopsModel.rows = value
KCM.SettingHighlighter {
highlight: kcm.desktopsModel.rows !== 2
}
function onRowsChanged() {
rowsSpinBox.value = kcm.desktopsModel.rows;
Connections {
target: kcm.desktopsModel
function onReadyChanged() {
rowsSpinBox.value = kcm.desktopsModel.rows;
}
function onRowsChanged() {
rowsSpinBox.value = kcm.desktopsModel.rows;
}
}
}
}
},
Kirigami.Action {
text: i18nc("@action:button", "Add")
text: i18nc("@action:button", "Add Desktop")
icon.name: "list-add"
onTriggered: kcm.desktopsModel.createDesktop()
}