yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop AbstractClient::addRepaintDuringGeometryUpdates()

Browse source 
It's not needed since the scene keeps track of repaints.
This commit is contained in:
Vlad Zahorodnii 2021-02-03 11:57:07 +02:00
parent 98b0b13f98
commit 36b55261da
4 changed files with 0 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/abstract_client.cpp
View file

@ -90,10 +90,6 @@ AbstractClient::AbstractClient()
}
);
connect(this, &AbstractClient::paddingChanged, this, [this]() {
m_visibleRectBeforeGeometryUpdate = visibleGeometry();
});
connect(ApplicationMenu::self(), &ApplicationMenu::applicationMenuEnabledChanged, this, [this] {
emit hasApplicationMenuChanged(hasApplicationMenu());
});
@ -936,7 +932,6 @@ void AbstractClient::move(int x, int y, ForceGeometry_t force)
emit bufferGeometryChanged(this, oldBufferGeometry);
emit clientGeometryChanged(this, oldClientGeometry);
emit frameGeometryChanged(this, oldFrameGeometry);
addRepaintDuringGeometryUpdates();
}
bool AbstractClient::startMoveResize()
@ -2058,14 +2053,6 @@ BORDER(Right)
BORDER(Top)
#undef BORDER
void AbstractClient::addRepaintDuringGeometryUpdates()
{
const QRect deco_rect = visibleGeometry();
addLayerRepaint(m_visibleRectBeforeGeometryUpdate);
addLayerRepaint(deco_rect); // trigger repaint of window's new location
m_visibleRectBeforeGeometryUpdate = deco_rect;
}
QRect AbstractClient::bufferGeometryBeforeUpdateBlocking() const
{
return m_bufferGeometryBeforeUpdateBlocking;

7
src/abstract_client.h
View file

@ -1059,12 +1059,6 @@ protected:
QRect frameGeometryBeforeUpdateBlocking() const;
QRect clientGeometryBeforeUpdateBlocking() const;
void updateGeometryBeforeUpdateBlocking();
/**
* Schedules a repaint for the visibleRect before and after a
* geometry update. The current visibleRect is stored for the
* next time this method is called as the before geometry.
*/
void addRepaintDuringGeometryUpdates();
/**
* @returns whether the Client is currently in move resize mode
@ -1299,7 +1293,6 @@ private:
int m_blockGeometryUpdates = 0; // > 0 = New geometry is remembered, but not actually set
PendingGeometry_t m_pendingGeometryUpdate = PendingGeometryNone;
friend class GeometryUpdatesBlocker;
QRect m_visibleRectBeforeGeometryUpdate;
QRect m_bufferGeometryBeforeUpdateBlocking;
QRect m_frameGeometryBeforeUpdateBlocking;
QRect m_clientGeometryBeforeUpdateBlocking;

3
src/waylandclient.cpp
View file

@ -419,7 +419,6 @@ void WaylandClient::move(int x, int y, ForceGeometry_t force)
emit bufferGeometryChanged(this, oldBufferGeometry);
emit clientGeometryChanged(this, oldClientGeometry);
emit frameGeometryChanged(this, oldFrameGeometry);
addRepaintDuringGeometryUpdates();
}
void WaylandClient::requestGeometry(const QRect &rect)
@ -467,8 +466,6 @@ void WaylandClient::updateGeometry(const QRect &rect)
emit frameGeometryChanged(this, oldFrameGeometry);
}
emit geometryShapeChanged(this, oldFrameGeometry);
addRepaintDuringGeometryUpdates();
}
void WaylandClient::setPositionSyncMode(SyncMode syncMode)

3
src/x11client.cpp
View file

@ -2779,7 +2779,6 @@ void X11Client::move(int x, int y, ForceGeometry_t force)
if (oldFrameGeometry != frameGeometry()) {
emit frameGeometryChanged(this, oldFrameGeometry);
}
addRepaintDuringGeometryUpdates();
}
bool X11Client::belongToSameApplication(const X11Client *c1, const X11Client *c2, SameApplicationChecks checks)
@ -4079,7 +4078,6 @@ void X11Client::setFrameGeometry(const QRect &rect, ForceGeometry_t force)
emit frameGeometryChanged(this, oldFrameGeometry);
}
emit geometryShapeChanged(this, oldFrameGeometry);
addRepaintDuringGeometryUpdates();
}
void X11Client::plainResize(int w, int h, ForceGeometry_t force)
@ -4142,7 +4140,6 @@ void X11Client::plainResize(int w, int h, ForceGeometry_t force)
emit frameGeometryChanged(this, oldFrameGeometry);
}
emit geometryShapeChanged(this, oldFrameGeometry);
addRepaintDuringGeometryUpdates();
}
void X11Client::updateServerGeometry()