yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

workspace: Add asserts to check double window insertion

Browse source 
We have a few crash reports that point to m_windows getting out of sync
with reality. Add some additional checks in the hope they point to
something useful.
This commit is contained in:
David Edmundson 2023-05-26 12:03:44 +01:00 committed by Vlad Zahorodnii
parent b42919e875
commit 3ccf560252
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/workspace.cpp
View file

@ -703,6 +703,7 @@ void Workspace::addX11Window(X11Window *window)
} else { } else {
m_focusChain->update(window, FocusChain::Update); m_focusChain->update(window, FocusChain::Update);
} }
Q_ASSERT(!m_windows.contains(window));
m_windows.append(window); m_windows.append(window);
addToStack(window); addToStack(window);
updateClientArea(); // This cannot be in manage(), because the window got added only now updateClientArea(); // This cannot be in manage(), because the window got added only now
@ -725,6 +726,7 @@ void Workspace::addX11Window(X11Window *window)
void Workspace::addUnmanaged(X11Window *window) void Workspace::addUnmanaged(X11Window *window)
{ {
Q_ASSERT(!m_windows.contains(window));
m_windows.append(window); m_windows.append(window);
addToStack(window); addToStack(window);
updateStackingOrder(true); updateStackingOrder(true);
@ -791,6 +793,7 @@ void Workspace::addWaylandWindow(Window *window)
m_placement->place(window, area); m_placement->place(window, area);
} }
} }
Q_ASSERT(!m_windows.contains(window));
m_windows.append(window); m_windows.append(window);
addToStack(window); addToStack(window);
@ -2017,6 +2020,7 @@ void Workspace::updateTabbox()
void Workspace::addInternalWindow(InternalWindow *window) void Workspace::addInternalWindow(InternalWindow *window)
{ {
Q_ASSERT(!m_windows.contains(window));
m_windows.append(window); m_windows.append(window);
addToStack(window); addToStack(window);