yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: Store hardware and virtual outputs in two different lists

Browse source 
Currently, we effectively almost everywhere need DrmOutput outputs,
DrmVirtualOutput outputs are needed only in a couple of places. There's
not a lot that we gain from storing real and virtual outputs in one
list, it adds unnecessary casting, etc. Ideally, virtual outputs must
come from a different backend, the current approach is not scalable.
This commit is contained in:
Vlad Zahorodnii 2022-09-07 10:00:59 +03:00
parent f73cb8f1e5
commit 3d1b3c9c66
3 changed files with 31 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/backends/drm/drm_backend.cpp
View file

@ -333,7 +333,7 @@ void DrmBackend::updateOutputs()
for (auto it = m_gpus.begin(); it < m_gpus.end();) {
auto gpu = it->get();
gpu->updateOutputs();
if (gpu->outputs().isEmpty() && gpu != primaryGpu()) {
if (gpu->drmOutputs().isEmpty() && gpu != primaryGpu()) {
qCDebug(KWIN_DRM) << "removing unused GPU" << gpu->devNode();
it = m_gpus.erase(it);
} else {
@ -473,11 +473,9 @@ bool DrmBackend::applyOutputChanges(const OutputConfiguration &config)
QVector<DrmOutput *> toBeEnabled;
QVector<DrmOutput *> toBeDisabled;
for (const auto &gpu : qAsConst(m_gpus)) {
const auto &outputs = gpu->outputs();
for (const auto &o : outputs) {
DrmOutput *output = qobject_cast<DrmOutput *>(o);
if (!output || output->isNonDesktop()) {
// virtual and non-desktop outputs don't need testing
const auto &outputs = gpu->drmOutputs();
for (const auto &output : outputs) {
if (output->isNonDesktop()) {
continue;
}
output->queueChanges(config);
@ -506,8 +504,9 @@ bool DrmBackend::applyOutputChanges(const OutputConfiguration &config)
output->applyQueuedChanges(config);
}
// only then apply changes to the virtual outputs
for (const auto &output : qAsConst(m_outputs)) {
if (!qobject_cast<DrmOutput *>(output)) {
for (const auto &gpu : qAsConst(m_gpus)) {
const auto &outputs = gpu->virtualOutputs();
for (const auto &output : outputs) {
output->applyChanges(config);
}
}

42
src/backends/drm/drm_gpu.cpp
View file

@ -114,13 +114,14 @@ DrmGpu::DrmGpu(DrmBackend *backend, const QString &devNode, int fd, dev_t device
DrmGpu::~DrmGpu()
{
waitIdle();
const auto outputs = m_outputs;
const auto outputs = m_drmOutputs;
for (const auto &output : outputs) {
if (auto drmOutput = qobject_cast<DrmOutput *>(output)) {
removeOutput(drmOutput);
} else {
removeVirtualOutput(dynamic_cast<DrmVirtualOutput *>(output));
}
removeOutput(output);
}
const auto virtualOutputs = m_virtualOutputs;
for (const auto &output : virtualOutputs) {
removeVirtualOutput(output);
}
if (m_eglDisplay != EGL_NO_DISPLAY) {
eglTerminate(m_eglDisplay);
@ -276,7 +277,6 @@ bool DrmGpu::updateOutputs()
m_pipelines << pipeline;
auto output = new DrmOutput(pipeline, m_leaseDevice);
m_drmOutputs << output;
m_outputs << output;
addedOutputs << output;
Q_EMIT outputAdded(output);
pipeline->setLayers(m_platform->renderBackend()->createPrimaryLayer(pipeline), m_platform->renderBackend()->createCursorLayer(pipeline));
@ -569,10 +569,9 @@ void DrmGpu::dispatchEvents()
void DrmGpu::removeOutput(DrmOutput *output)
{
qCDebug(KWIN_DRM) << "Removing output" << output;
m_drmOutputs.removeOne(output);
m_pipelines.removeOne(output->pipeline());
output->pipeline()->setLayers(nullptr, nullptr);
m_outputs.removeOne(output);
m_drmOutputs.removeOne(output);
Q_EMIT outputRemoved(output);
delete output;
}
@ -590,14 +589,14 @@ const QVector<DrmPipeline *> DrmGpu::pipelines() const
DrmVirtualOutput *DrmGpu::createVirtualOutput(const QString &name, const QSize &size, double scale)
{
auto output = new DrmVirtualOutput(name, this, size, scale);
m_outputs << output;
m_virtualOutputs << output;
Q_EMIT outputAdded(output);
return output;
}
void DrmGpu::removeVirtualOutput(DrmVirtualOutput *output)
{
if (m_outputs.removeOne(output)) {
if (m_virtualOutputs.removeOne(output)) {
Q_EMIT outputRemoved(output);
delete output;
}
@ -655,9 +654,14 @@ void DrmGpu::handleLeaseRevoked(KWaylandServer::DrmLeaseV1Interface *lease)
drmModeRevokeLease(m_fd, lease->lesseeId());
}
QVector<DrmAbstractOutput *> DrmGpu::outputs() const
QVector<DrmVirtualOutput *> DrmGpu::virtualOutputs() const
{
return m_outputs;
return m_virtualOutputs;
}
QVector<DrmOutput *> DrmGpu::drmOutputs() const
{
return m_drmOutputs;
}
int DrmGpu::fd() const
@ -782,10 +786,8 @@ void DrmGpu::releaseBuffers()
pipeline->primaryLayer()->releaseBuffers();
pipeline->cursorLayer()->releaseBuffers();
}
for (const auto &output : qAsConst(m_outputs)) {
if (const auto virtualOutput = qobject_cast<DrmVirtualOutput *>(output)) {
virtualOutput->outputLayer()->releaseBuffers();
}
for (const auto &output : qAsConst(m_virtualOutputs)) {
output->outputLayer()->releaseBuffers();
}
}
@ -795,10 +797,8 @@ void DrmGpu::recreateSurfaces()
pipeline->setLayers(m_platform->renderBackend()->createPrimaryLayer(pipeline), m_platform->renderBackend()->createCursorLayer(pipeline));
pipeline->applyPendingChanges();
}
for (const auto &output : qAsConst(m_outputs)) {
if (const auto virtualOutput = qobject_cast<DrmVirtualOutput *>(output)) {
virtualOutput->recreateSurface();
}
for (const auto &output : qAsConst(m_virtualOutputs)) {
output->recreateSurface();
}
for (const auto &output : qAsConst(m_drmOutputs)) {
output->updateCursor();

5
src/backends/drm/drm_gpu.h
View file

@ -67,7 +67,8 @@ public:
clockid_t presentationClock() const;
QSize cursorSize() const;
QVector<DrmAbstractOutput *> outputs() const;
QVector<DrmVirtualOutput *> virtualOutputs() const;
QVector<DrmOutput *> drmOutputs() const;
const QVector<DrmPipeline *> pipelines() const;
void setEglDisplay(EGLDisplay display);
@ -123,7 +124,7 @@ private:
QVector<DrmPipeline *> m_pipelines;
QVector<DrmOutput *> m_drmOutputs;
QVector<DrmAbstractOutput *> m_outputs;
QVector<DrmVirtualOutput *> m_virtualOutputs;
KWaylandServer::DrmLeaseDeviceV1Interface *m_leaseDevice = nullptr;
QSocketNotifier *m_socketNotifier = nullptr;