yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[server] Add resource check in QtExtendedSurfaceInterface::close

Browse source 
Summary:
The QtExtendedSurfaceInterface might be unbound and thus the resource
might be null when calling into close. Thus we need to do a nullptr
check.

Hit a crash there.

Test Plan:
Unfortunately no test case as we don't have a client side
implementation for this.

Reviewers: #plasma_on_wayland

Subscribers: plasma-devel

Tags: #plasma_on_wayland

Differential Revision: https://phabricator.kde.org/D1961
This commit is contained in:
Martin Gräßlin 2016-06-20 16:25:15 +02:00
parent 262b49d713
commit 3f69ab1bf0
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/wayland/server/qtsurfaceextension_interface.cpp
View file

@ -219,6 +219,9 @@ QtExtendedSurfaceInterface::Private *QtExtendedSurfaceInterface::d_func() const
void QtExtendedSurfaceInterface::close() void QtExtendedSurfaceInterface::close()
{ {
Q_D(); Q_D();
if (!d->resource) {
return;
}
qt_extended_surface_send_close(d->resource); qt_extended_surface_send_close(d->resource);
d->client->flush(); d->client->flush();
} }