From 4001834da8c325331cacd0d046a90d46b8557e1e Mon Sep 17 00:00:00 2001 From: Marco Martin Date: Mon, 10 Dec 2018 16:41:56 +0100 Subject: [PATCH] fix virtual keyboard on Plasma Mobile Summary: the newly introduced resize button shouldn't be visible on the phone and for some reason using a ToolButton prevents the qml to load at all on the phone (the problem seems right into the C++ part of ToolButton as is broken on every QQC2 style) Test Plan: work again on phone, still work on laptop Reviewers: #plasma, bshah Reviewed By: #plasma, bshah Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17483 --- qml/virtualkeyboard/main.qml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qml/virtualkeyboard/main.qml b/qml/virtualkeyboard/main.qml index 2b8e5cc686..ef1a967f3d 100644 --- a/qml/virtualkeyboard/main.qml +++ b/qml/virtualkeyboard/main.qml @@ -20,6 +20,7 @@ along with this program. If not, see . import QtQuick 2.0 import QtQuick.Controls 2.3 import QtQuick.VirtualKeyboard 2.1 +import org.kde.kirigami 2.5 as Kirigami Item { id: window @@ -32,8 +33,10 @@ Item { anchors.horizontalCenter: parent.horizontalCenter anchors.bottom: parent.bottom } - ToolButton { + //NOTE: ToolButton for some reasons breaks the virtual keyboard loading on Plasma Mobile + Button { id: resizeButton + visible: !Kirigami.Settings.isMobile //don't show on handheld devices flat: true display: AbstractButton.IconOnly icon.name: "transform-scale"