From 41b02f235626b35344d3cb7268c6c16dde01f37a Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Fri, 28 Feb 2020 11:41:59 +0000 Subject: [PATCH] [x11client] Make activity handling more consistent across windows Summary: Typically by default newly added toplevel windows are added only to the current activity. Initially windows with no borders were added to all activities. This causes problems particularly now with the newer frame extents support leaving window behaviour quite inconsistent. Since the time of the original code the taskbar gained control for controlling activities allowing at least one method of changing them. This means we can use this as the new filter. BUG: 274931 Test Plan: Opened gtk3-demo Switched activities, it wasn't on the new one Went back, altered it through the taskmanager, it worked Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27690 --- x11client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x11client.cpp b/x11client.cpp index f6b10d48d0..99294874e8 100644 --- a/x11client.cpp +++ b/x11client.cpp @@ -518,7 +518,7 @@ bool X11Client::manage(xcb_window_t w, bool isMapped) desk = asn_data.desktop(); } #ifdef KWIN_BUILD_ACTIVITIES - if (Activities::self() && !isMapped && !noborder && isNormalWindow() && !activitiesDefined) { + if (Activities::self() && !isMapped && !skipTaskbar() && isNormalWindow() && !activitiesDefined) { //a new, regular window, when we're not recovering from a crash, //and it hasn't got an activity. let's try giving it the current one. //TODO: decide whether to keep this before the 4.6 release