yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check for subsurface loops

Browse source 
If subsurfaces form a loop, kwin will get stuck in an infinite
recursion while it constructs a window pixmap tree.
This commit is contained in:
Vlad Zahorodnii 2020-11-04 23:34:10 +02:00
parent 0ed0066d74
commit 426e41f500
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/wayland/subcompositor_interface.cpp
View file

@ -50,6 +50,19 @@ void SubCompositorInterfacePrivate::subcompositor_get_subsurface(Resource *resou
return;
}
if (surface == parent) {
wl_resource_post_error(resource->handle, error_bad_surface,
"wl_surface@%d cannot be its own parent",
wl_resource_get_id(surface_resource));
return;
}
if (parent->subSurface() && parent->subSurface()->mainSurface() == surface) {
wl_resource_post_error(resource->handle, error_bad_surface,
"wl_surface@%d is an ancestor of parent",
wl_resource_get_id(surface_resource));
return;
}
wl_resource *subsurfaceResource = wl_resource_create(resource->client(), &wl_subsurface_interface,
resource->version(), id);
if (!subsurfaceResource) {