From 436187762ef67d0c127fd335959fd7654f676114 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Tue, 15 Feb 2022 12:58:43 +0200 Subject: [PATCH] kwinglutils: Deprecate GLTexture dirty state tracking It's currently being used only by the X11 standalone backend. We should either port the X11 backend to manual dirty state tracking or waiting until it gets dropped. The main motivation for getting rid of the dirty state tracking in the GLTexture is that it keeps kwin open for alternative opengl wrappers, e.g. QOpenGL, and it simplifies GLTexture code. --- src/libkwineffects/kwingltexture.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libkwineffects/kwingltexture.h b/src/libkwineffects/kwingltexture.h index c184cb4b60..b346369b01 100644 --- a/src/libkwineffects/kwingltexture.h +++ b/src/libkwineffects/kwingltexture.h @@ -117,10 +117,13 @@ public: * Make the texture fully transparent */ void clear(); + /** + * @deprecated track modifications to the texture yourself + */ + void setDirty(); bool isDirty() const; void setFilter(GLenum filter); void setWrapMode(GLenum mode); - void setDirty(); void generateMipmaps();