From 43816119e9ec74df228b42163b087e51b7541884 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Fl=C3=B6ser?= Date: Wed, 28 Jun 2017 21:55:22 +0200 Subject: [PATCH] Skip Shader self test for Mesa >= 17 Summary: We are getting reports about the shader self test failing in a false positive way on Mesa 17. We already have such false positve results for NVIDIA quadro and went with disabling the self test. Most likely our self test has a problem or the rendering of the first frame has a problem. But disabling compositing because our rendering of the first frame is broken, is too much. Let's better be pro user here and disable the shader self test till we fixed the root problem. BUG: 376801 FIXED-IN: 5.10.4 Test Plan: It compiles. Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6426 --- libkwineffects/kwinglutils.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libkwineffects/kwinglutils.cpp b/libkwineffects/kwinglutils.cpp index cbf2a74842..8f7ce38ca0 100644 --- a/libkwineffects/kwinglutils.cpp +++ b/libkwineffects/kwinglutils.cpp @@ -614,6 +614,10 @@ bool ShaderManager::selfTest() qCWarning(LIBKWINGLUTILS) << "Skipping self test as it is reported to return false positive results on Quadro hardware"; return true; } + if (GLPlatform::instance()->isMesaDriver() && GLPlatform::instance()->mesaVersion() >= kVersionNumber(17, 0)) { + qCWarning(LIBKWINGLUTILS) << "Skipping self test as it is reported to return false positive results on Mesa drivers"; + return true; + } // Create the source texture QImage image(2, 2, QImage::Format_ARGB32_Premultiplied);