yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve partial maximization strings

Browse source 
Summary:
e.g. "Vertically maximize" is more natural and expressive than "Maximize (vertical only)"

See D29671#inline-169882.

Test Plan: New strings appear in the KCM

Reviewers: zzag, #vdg, #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29729
This commit is contained in:
Nate Graham 2020-05-13 12:11:44 -06:00
parent c483e209fe
commit 45bf53adab
4 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
kcmkwin/kwinoptions/kwinoptions_settings.kcfg
View file

@ -62,8 +62,8 @@
<default>Maximize</default>
<choices>
<choice name="Maximize"></choice>
<choice name="MaximizeVerticalOnly" value="Maximize (vertical only)"></choice>
<choice name="MaximizeHorizontalOnly" value="Maximize (horizontal only)"></choice>
<choice name="MaximizeVerticalOnly" value="Vertically maximize"></choice>
<choice name="MaximizeHorizontalOnly" value="Horizontally maximize"></choice>
<choice name="Minimize"></choice>
<choice name="Shade"></choice>
<choice name="Lower"></choice>
@ -77,8 +77,8 @@
<default>Maximize</default>
<choices>
<choice name="Maximize"></choice>
<choice name="MaximizeVerticalOnly" value="Maximize (vertical only)"></choice>
<choice name="MaximizeHorizontalOnly" value="Maximize (horizontal only)"></choice>
<choice name="MaximizeVerticalOnly" value="Vertically maximize"></choice>
<choice name="MaximizeHorizontalOnly" value="Horizontally maximize"></choice>
</choices>
</entry>
@ -86,8 +86,8 @@
<default>MaximizeVerticalOnly</default>
<choices>
<choice name="Maximize"></choice>
<choice name="MaximizeVerticalOnly" value="Maximize (vertical only)"></choice>
<choice name="MaximizeHorizontalOnly" value="Maximize (horizontal only)"></choice>
<choice name="MaximizeVerticalOnly" value="Vertically maximize"></choice>
<choice name="MaximizeHorizontalOnly" value="Horizontally maximize"></choice>
</choices>
</entry>
@ -95,8 +95,8 @@
<default>MaximizeHorizontalOnly</default>
<choices>
<choice name="Maximize"></choice>
<choice name="MaximizeVerticalOnly" value="Maximize (vertical only)"></choice>
<choice name="MaximizeHorizontalOnly" value="Maximize (horizontal only)"></choice>
<choice name="MaximizeVerticalOnly" value="Vertically maximize"></choice>
<choice name="MaximizeHorizontalOnly" value="Horizontally maximize"></choice>
</choices>
</entry>

16
kcmkwin/kwinoptions/mouse.ui
View file

@ -42,12 +42,12 @@
</item>
<item>
<property name="text">
<string extracomment="@item:inlistbox behavior on double click">Maximize (vertical only)</string>
<string extracomment="@item:inlistbox behavior on double click">Vertically maximize</string>
</property>
</item>
<item>
<property name="text">
<string extracomment="@item:inlistbox behavior on double click">Maximize (horizontal only)</string>
<string extracomment="@item:inlistbox behavior on double click">Horizontally maximize</string>
</property>
</item>
<item>
@ -617,12 +617,12 @@
</item>
<item>
<property name="text">
<string>Maximize (vertical only)</string>
<string>Vertically maximize</string>
</property>
</item>
<item>
<property name="text">
<string>Maximize (horizontal only)</string>
<string>Horizontally maximize</string>
</property>
</item>
</widget>
@ -652,12 +652,12 @@
</item>
<item>
<property name="text">
<string>Maximize (vertical only)</string>
<string>Vertically maximize</string>
</property>
</item>
<item>
<property name="text">
<string>Maximize (horizontal only)</string>
<string>Horizontally maximize</string>
</property>
</item>
</widget>
@ -687,12 +687,12 @@
</item>
<item>
<property name="text">
<string>Maximize (vertical only)</string>
<string>Vertically maximize</string>
</property>
</item>
<item>
<property name="text">
<string>Maximize (horizontal only)</string>
<string>Horizontally maximize</string>
</property>
</item>
</widget>

4
kwin.kcfg
View file

@ -189,10 +189,10 @@
<default>Maximize</default>
</entry>
<entry name="MaximizeButtonMiddleClickCommand" type="String">
<default>Maximize (vertical only)</default>
<default>Vertically maximize</default>
</entry>
<entry name="MaximizeButtonRightClickCommand" type="String">
<default>Maximize (horizontal only)</default>
<default>Horizontally maximize</default>
</entry>
<entry name="KillPingTimeout" type="Int">
<default>5000</default>

6
options.cpp
View file

@ -758,7 +758,7 @@ void Options::loadConfig()
KConfigGroup config(m_settings->config(), "Windows");
OpTitlebarDblClick = windowOperation(config.readEntry("TitlebarDoubleClickCommand", "Maximize"), true);
setOperationMaxButtonLeftClick(windowOperation(config.readEntry("MaximizeButtonLeftClickCommand", "Maximize"), true));
setOperationMaxButtonMiddleClick(windowOperation(config.readEntry("MaximizeButtonMiddleClickCommand", "Maximize (vertical only)"), true));
setOperationMaxButtonMiddleClick(windowOperation(config.readEntry("MaximizeButtonMiddleClickCommand", "Vertically Maximize"), true));
setOperationMaxButtonRightClick(windowOperation(config.readEntry("MaximizeButtonRightClickCommand", "Maximize (horizontal only)"), true));
// Mouse bindings
@ -982,9 +982,9 @@ Options::WindowOperation Options::windowOperation(const QString &name, bool rest
return ShadeOp;
else if (name == QStringLiteral("Operations"))
return OperationsOp;
else if (name == QStringLiteral("Maximize (vertical only)"))
else if (name == QStringLiteral("Vertically maximize"))
return VMaximizeOp;
else if (name == QStringLiteral("Maximize (horizontal only)"))
else if (name == QStringLiteral("Horizontally maximize"))
return HMaximizeOp;
else if (name == QStringLiteral("Lower"))
return LowerOp;