yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[kcmkwin/compositing] Set a maximumWidth on the text elements in Effect

Browse source 
By properly setting Layout.maximumWidth the buttons are not moved out of
the layout. Instead the text wraps to a new line.

BUG: 335078
REVIEW: 118222
This commit is contained in:
Martin Gräßlin 2014-05-20 15:31:03 +02:00
parent 0eaf41df85
commit 45f1060da0
1 changed files with 52 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

91
kcmkwin/kwincompositing/qml/Effect.qml
View file

@ -41,72 +41,85 @@ Rectangle {
RowLayout {
id: rowEffect
width: parent.width - 2 * spacing
property int maximumWidth: parent.width - 2 * spacing
width: maximumWidth
Layout.maximumWidth: maximumWidth
x: spacing
RadioButton {
id: exclusiveGroupButton
property bool exclusive: model.ExclusiveRole != ""
visible: exclusive
checked: model.EffectStatusRole
property bool actuallyChanged: true
property bool initiallyChecked: false
exclusiveGroup: exclusive ? effectView.exclusiveGroupForCategory(model.ExclusiveRole) : null
onCheckedChanged: {
if (!visible) {
return;
RowLayout {
id: checkBoxLayout
RadioButton {
id: exclusiveGroupButton
property bool exclusive: model.ExclusiveRole != ""
visible: exclusive
checked: model.EffectStatusRole
property bool actuallyChanged: true
property bool initiallyChecked: false
exclusiveGroup: exclusive ? effectView.exclusiveGroupForCategory(model.ExclusiveRole) : null
onCheckedChanged: {
if (!visible) {
return;
}
actuallyChanged = true;
item.checked = exclusiveGroupButton.checked
item.changed();
}
actuallyChanged = true;
item.checked = exclusiveGroupButton.checked
item.changed();
}
onClicked: {
if (!actuallyChanged || initiallyChecked) {
checked = false;
onClicked: {
if (!actuallyChanged || initiallyChecked) {
checked = false;
}
actuallyChanged = false;
initiallyChecked = false;
}
Component.onCompleted: {
exclusiveGroupButton.initiallyChecked = model.EffectStatusRole;
}
actuallyChanged = false;
initiallyChecked = false;
}
Component.onCompleted: {
exclusiveGroupButton.initiallyChecked = model.EffectStatusRole;
}
}
CheckBox {
id: effectStatusCheckBox
checked: model.EffectStatusRole
visible: model.ExclusiveRole == ""
CheckBox {
id: effectStatusCheckBox
checked: model.EffectStatusRole
visible: model.ExclusiveRole == ""
onCheckedChanged: {
if (!visible) {
return;
onCheckedChanged: {
if (!visible) {
return;
}
item.checked = effectStatusCheckBox.checked;
item.changed();
}
item.checked = effectStatusCheckBox.checked;
item.changed();
}
Connections {
target: searchModel
onDataChanged: {
effectStatusCheckBox.checked = model.EffectStatusRole;
Connections {
target: searchModel
onDataChanged: {
effectStatusCheckBox.checked = model.EffectStatusRole;
}
}
}
}
ColumnLayout {
id: effectItem
property int maximumWidth: parent.maximumWidth - checkBoxLayout.width - (videoButton.width + configureButton.width + aboutButton.width) - parent.spacing * 5
Layout.maximumWidth: maximumWidth
Text {
text: model.NameRole
font.bold: true
wrapMode: Text.Wrap
Layout.maximumWidth: parent.maximumWidth
}
Text {
id: desc
text: model.DescriptionRole
wrapMode: Text.Wrap
Layout.maximumWidth: parent.maximumWidth
}
Text {
id:aboutItem
text: i18n("Author: %1\nLicense: %2", model.AuthorNameRole, model.LicenseRole)
font.bold: true
visible: false
wrapMode: Text.Wrap
Layout.maximumWidth: parent.maximumWidth
}
Video {
id: videoItem