yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[platforms/drm] Refactor updateTransform

Browse source 
Summary:
Small intermediate refactor. For now just do the normal rotation when a flipped
transform is requested. In the future we might want to provide the possibility
to flip the output image.

Test Plan: Compiles

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D25649
This commit is contained in:
Roman Gilg 2019-12-01 12:51:38 +01:00
parent f21f61db38
commit 47306865a7
1 changed files with 18 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
plugins/platforms/drm/drm_output.cpp
View file

@ -651,41 +651,36 @@ bool DrmOutput::dpmsLegacyApply()
void DrmOutput::updateTransform(Transform transform)
{
DrmPlane::Transformation planeTransform;
// TODO: Do we want to support reflections (flips)?
switch (transform) {
case Transform::Normal:
if (m_primaryPlane) {
m_primaryPlane->setTransformation(DrmPlane::Transformation::Rotate0);
}
case Transform::Flipped:
planeTransform = DrmPlane::Transformation::Rotate0;
break;
case Transform::Rotated90:
if (m_primaryPlane) {
m_primaryPlane->setTransformation(DrmPlane::Transformation::Rotate90);
}
case Transform::Flipped90:
planeTransform = DrmPlane::Transformation::Rotate90;
break;
case Transform::Rotated180:
if (m_primaryPlane) {
m_primaryPlane->setTransformation(DrmPlane::Transformation::Rotate180);
}
case Transform::Flipped180:
planeTransform = DrmPlane::Transformation::Rotate180;
break;
case Transform::Rotated270:
if (m_primaryPlane) {
m_primaryPlane->setTransformation(DrmPlane::Transformation::Rotate270);
}
break;
case Transform::Flipped:
// TODO: what is this exactly?
break;
case Transform::Flipped90:
// TODO: what is this exactly?
break;
case Transform::Flipped180:
// TODO: what is this exactly?
break;
case Transform::Flipped270:
// TODO: what is this exactly?
planeTransform = DrmPlane::Transformation::Rotate270;
break;
default:
Q_UNREACHABLE();
}
if (m_primaryPlane) {
m_primaryPlane->setTransformation(planeTransform);
}
m_modesetRequested = true;
// the cursor might need to get rotated
updateCursor();
showCursor();