From 4b97bc481e4d93614cade6910a952269bdd96308 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Wed, 2 Feb 2022 19:00:50 +0200 Subject: [PATCH] effects/presentwindows: Fix crash The present windows effect can crash because a null (0) EffectScreen can be passed to EffectsHandler::clientArea(), which is a bug. Use EffectsHandler::virtualScreenGeometry() to get the bounding geometry of all outputs. BUG: 449508 --- src/effects/presentwindows/presentwindows.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/effects/presentwindows/presentwindows.cpp b/src/effects/presentwindows/presentwindows.cpp index 563c2bf205..ce6bc6566b 100644 --- a/src/effects/presentwindows/presentwindows.cpp +++ b/src/effects/presentwindows/presentwindows.cpp @@ -1863,7 +1863,7 @@ EffectWindow* PresentWindowsEffect::relativeWindow(EffectWindow *w, int xdiff, i // TODO: Is it possible to select hidden windows? EffectWindow* next; - QRect area = effects->clientArea(FullArea, 0, effects->currentDesktop()); + QRect area = effects->virtualScreenGeometry(); QRect detectRect; // Detect across the width of the desktop