yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

exclude non opaque (NOT "non ARGB") windows from lanczos filter unless we've a working blendfunction for the cached texture

Browse source 
BUG: 258439

svn path=/trunk/KDE/kdebase/workspace/; revision=1207826
This commit is contained in:
Thomas Lübking 2010-12-19 21:32:02 +00:00
parent e2dcfff601
commit 4cf251436f
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lanczosfilter.cpp
View file

@ -170,7 +170,7 @@ void LanczosShader::createOffsets( int count, float width, Qt::Orientation direc
void LanczosFilter::performPaint( EffectWindowImpl* w, int mask, QRegion region, WindowPaintData& data ) void LanczosFilter::performPaint( EffectWindowImpl* w, int mask, QRegion region, WindowPaintData& data )
{ {
#ifdef KWIN_HAVE_OPENGL_COMPOSITING #ifdef KWIN_HAVE_OPENGL_COMPOSITING
if( effects->compositingType() == KWin::OpenGLCompositing && if( effects->compositingType() == KWin::OpenGLCompositing && data.opacity == 1.0 &&
KGlobalSettings::graphicEffectsLevel() & KGlobalSettings::SimpleAnimationEffects ) KGlobalSettings::graphicEffectsLevel() & KGlobalSettings::SimpleAnimationEffects )
{ {
if (!m_inited) if (!m_inited)
@ -216,7 +216,6 @@ void LanczosFilter::performPaint( EffectWindowImpl* w, int mask, QRegion region,
if( cachedTexture->width() == tw && cachedTexture->height() == th ) if( cachedTexture->width() == tw && cachedTexture->height() == th )
{ {
cachedTexture->bind(); cachedTexture->bind();
data.opacity *= 0.99;
prepareRenderStates( cachedTexture, data.opacity, data.brightness, data.saturation ); prepareRenderStates( cachedTexture, data.opacity, data.brightness, data.saturation );
cachedTexture->render( textureRect, textureRect ); cachedTexture->render( textureRect, textureRect );
restoreRenderStates( cachedTexture, data.opacity, data.brightness, data.saturation ); restoreRenderStates( cachedTexture, data.opacity, data.brightness, data.saturation );
@ -361,7 +360,7 @@ void LanczosFilter::timerEvent( QTimerEvent *event )
void LanczosFilter::prepareRenderStates( GLTexture* tex, double opacity, double brightness, double saturation ) void LanczosFilter::prepareRenderStates( GLTexture* tex, double opacity, double brightness, double saturation )
{ {
#ifdef KWIN_HAVE_OPENGL_COMPOSITING #ifdef KWIN_HAVE_OPENGL_COMPOSITING
const bool alpha = false; // true; WORKAROUND - "true" causes issues with at least nvidia chips and translucent windows "overbrightning" const bool alpha = true;
// setup blending of transparent windows // setup blending of transparent windows
glPushAttrib( GL_ENABLE_BIT ); glPushAttrib( GL_ENABLE_BIT );
glEnable( GL_BLEND ); glEnable( GL_BLEND );