yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rules kcm, detection use X11 to grab the pointer

Browse source 
BUG: 318437
REVIEW: 110078
FIXED-IN: 4.11
This commit is contained in:
Thomas Lübking 2013-04-18 20:10:15 +02:00
parent d2f9d8feee
commit 4ec1a9bb3a
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
kcmkwin/kwinrules/detectwidget.cpp
View file

@ -172,8 +172,18 @@ void DetectDialog::selectWindow()
grabber->move(-1000, -1000); grabber->move(-1000, -1000);
grabber->setModal(true); grabber->setModal(true);
grabber->show(); grabber->show();
grabber->grabMouse(Qt::CrossCursor); // Qt uses QX11Info::appTime() to grab the pointer, what can silently fail (#318437) ...
XSync(QX11Info::display(), false);
if (XGrabPointer(QX11Info::display(), grabber->winId(), false, ButtonReleaseMask,
GrabModeAsync, GrabModeAsync, None, QCursor(Qt::CrossCursor).handle(),
CurrentTime) == Success) { // ...so we use the far more convincing CurrentTime
grabber->grabMouse(Qt::CrossCursor); // do anyway, so that Qt updates the mouseGrabber info
grabber->installEventFilter(this); grabber->installEventFilter(this);
} else {
// ... and if we fail, cleanup, so we won't receive random events
delete grabber;
grabber = 0;
}
} }
bool DetectDialog::eventFilter(QObject* o, QEvent* e) bool DetectDialog::eventFilter(QObject* o, QEvent* e)