From 4f484180cd1eb32b9bda0d96eb50c12ca5876941 Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Wed, 18 Nov 2020 15:08:54 +0100 Subject: [PATCH] Add emit to signal calls To signify they're emitting. --- kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp | 2 +- kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp | 4 ++-- kcmkwin/kwindesktop/desktopsmodel.cpp | 4 ++-- libkwineffects/kwineffectquickview.cpp | 2 +- plugins/platforms/wayland/wayland_backend.cpp | 2 +- tabletmodemanager.cpp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp b/kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp index 9a0fb14e6b..005c051df9 100644 --- a/kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp +++ b/kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp @@ -91,7 +91,7 @@ PreviewClient::PreviewClient(DecoratedClient *c, Decoration *decoration) emit paletteChanged(m_palette.palette()); }); auto emitEdgesChanged = [this, c]() { - c->adjacentScreenEdgesChanged(adjacentScreenEdges()); + emit c->adjacentScreenEdgesChanged(adjacentScreenEdges()); }; connect(this, &PreviewClient::bordersTopEdgeChanged, this, emitEdgesChanged); connect(this, &PreviewClient::bordersLeftEdgeChanged, this, emitEdgesChanged); diff --git a/kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp b/kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp index cc931aa9c5..0e71917ab4 100644 --- a/kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp +++ b/kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp @@ -88,10 +88,10 @@ PreviewSettings::PreviewSettings(DecorationSettings *parent) connect(this, &PreviewSettings::closeOnDoubleClickOnMenuChanged, parent, &DecorationSettings::closeOnDoubleClickOnMenuChanged); connect(this, &PreviewSettings::fontChanged, parent, &DecorationSettings::fontChanged); auto updateLeft = [this, parent]() { - parent->decorationButtonsLeftChanged(decorationButtonsLeft()); + emit parent->decorationButtonsLeftChanged(decorationButtonsLeft()); }; auto updateRight = [this, parent]() { - parent->decorationButtonsRightChanged(decorationButtonsRight()); + emit parent->decorationButtonsRightChanged(decorationButtonsRight()); }; connect(m_leftButtons, &QAbstractItemModel::rowsRemoved, this, updateLeft); connect(m_leftButtons, &QAbstractItemModel::rowsMoved, this, updateLeft); diff --git a/kcmkwin/kwindesktop/desktopsmodel.cpp b/kcmkwin/kwindesktop/desktopsmodel.cpp index da1d4d9a07..7d0ad09207 100644 --- a/kcmkwin/kwindesktop/desktopsmodel.cpp +++ b/kcmkwin/kwindesktop/desktopsmodel.cpp @@ -222,7 +222,7 @@ void DesktopsModel::setDesktopName(const QString &id, const QString &name) const QModelIndex &idx = index(m_desktops.indexOf(id), 0); - dataChanged(idx, idx, QVector{Qt::DisplayRole}); + emit dataChanged(idx, idx, QVector{Qt::DisplayRole}); updateModifiedState(); } @@ -573,7 +573,7 @@ void DesktopsModel::desktopDataChanged(const QString &id, const KWin::DBusDeskto const QModelIndex &idx = index(desktopIndex, 0); - dataChanged(idx, idx, QVector{Qt::DisplayRole}); + emit dataChanged(idx, idx, QVector{Qt::DisplayRole}); } else { updateModifiedState(/* server */ true); } diff --git a/libkwineffects/kwineffectquickview.cpp b/libkwineffects/kwineffectquickview.cpp index dae215532d..a061417a51 100644 --- a/libkwineffects/kwineffectquickview.cpp +++ b/libkwineffects/kwineffectquickview.cpp @@ -260,7 +260,7 @@ void EffectQuickView::setVisible(bool visible) d->m_visible = visible; if (visible){ - d->m_renderControl->renderRequested(); + emit d->m_renderControl->renderRequested(); } else { // deferred to not change GL context QTimer::singleShot(0, this, [this]() { diff --git a/plugins/platforms/wayland/wayland_backend.cpp b/plugins/platforms/wayland/wayland_backend.cpp index d12e1d55af..15ed841015 100644 --- a/plugins/platforms/wayland/wayland_backend.cpp +++ b/plugins/platforms/wayland/wayland_backend.cpp @@ -562,7 +562,7 @@ void WaylandBackend::init() } m_waylandCursor->installImage(); auto c = Cursors::self()->currentCursor(); - c->rendered(c->geometry()); + emit c->rendered(c->geometry()); } ); connect(this, &WaylandBackend::pointerLockChanged, this, [this] (bool locked) { diff --git a/tabletmodemanager.cpp b/tabletmodemanager.cpp index 04221ee163..f952d1835a 100644 --- a/tabletmodemanager.cpp +++ b/tabletmodemanager.cpp @@ -152,7 +152,7 @@ void KWin::TabletModeManager::setTabletModeAvailable(bool detecting) { if (m_detecting != detecting) { m_detecting = detecting; - tabletModeAvailableChanged(detecting); + emit tabletModeAvailableChanged(detecting); } }