From 5193658aa23409da5c6bf8da5cef7c64dd9e332b Mon Sep 17 00:00:00 2001
From: Michael Tunnell <m@michaeltunnell.com>
Date: Mon, 4 Jan 2021 01:52:39 +0000
Subject: [PATCH] Apply Initially as default value of new Properties

Change the default value from "Do Not Affect" to "Apply Initially" when
adding new properties in Window Rules.

REASON: prior "Do Not Affect" as default and occasionally I forget to
change the setting to something else when adding new properties.
Unfortunately, this means I forget to do it and so it isn't saved when
I close the window. I will then go back in to change it to Apply Initially
or in some cases have to add the new property again as it wasn't saved in
the set.

I think if Apply Initially were to be the default it would be an easier
and faster experience to add new properties.
---
 kcmkwin/kwinrules/optionsmodel.cpp | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/kcmkwin/kwinrules/optionsmodel.cpp b/kcmkwin/kwinrules/optionsmodel.cpp
index a8f6467686..8086ff473a 100644
--- a/kcmkwin/kwinrules/optionsmodel.cpp
+++ b/kcmkwin/kwinrules/optionsmodel.cpp
@@ -140,25 +140,25 @@ QList<RulePolicy::Data> RulePolicy::policyOptions(RulePolicy::Type type)
     };
 
     static const auto setRuleOptions = QList<RulePolicy::Data> {
-        {Rules::DontAffect,
-            i18n("Do Not Affect"),
-            i18n("The window property will not be affected and therefore the default handling for it will be used."
-                 "\nSpecifying this will block more generic window settings from taking effect.")},
         {Rules::Apply,
             i18n("Apply Initially"),
             i18n("The window property will be only set to the given value after the window is created."
                  "\nNo further changes will be affected.")},
-        {Rules::Remember,
-            i18n("Remember"),
-            i18n("The value of the window property will be remembered and, every time the window"
-                 " is created, the last remembered value will be applied.")},
-        {Rules::Force,
-            i18n("Force"),
-            i18n("The window property will be always forced to the given value.")},
         {Rules::ApplyNow,
             i18n("Apply Now"),
             i18n("The window property will be set to the given value immediately and will not be affected later"
                  "\n(this action will be deleted afterwards).")},
+        {Rules::Remember,
+            i18n("Remember"),
+            i18n("The value of the window property will be remembered and, every time the window"
+                 " is created, the last remembered value will be applied.")},
+        {Rules::DontAffect,
+            i18n("Do Not Affect"),
+            i18n("The window property will not be affected and therefore the default handling for it will be used."
+                 "\nSpecifying this will block more generic window settings from taking effect.")},
+        {Rules::Force,
+            i18n("Force"),
+            i18n("The window property will be always forced to the given value.")},
         {Rules::ForceTemporarily,
             i18n("Force Temporarily"),
             i18n("The window property will be forced to the given value until it is hidden"
@@ -166,9 +166,9 @@ QList<RulePolicy::Data> RulePolicy::policyOptions(RulePolicy::Type type)
     };
 
     static auto forceRuleOptions = QList<RulePolicy::Data> {
-        setRuleOptions.at(0),  // Rules::DontAffect
-        setRuleOptions.at(3),  // Rules::Force
+        setRuleOptions.at(4),  // Rules::Force
         setRuleOptions.at(5),  // Rules::ForceTemporarily
+        setRuleOptions.at(3),  // Rules::DontAffect
     };
 
     switch (type) {