From 51c3c6cc420fc8768d1a15b3c83de898f46016f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20L=C3=BCbking?= Date: Sat, 7 Sep 2013 23:35:06 +0200 Subject: [PATCH] no VD change for activation & unreasonable policy F(S)UM mean "the focus is where the mouse is" the mouse is not on the other virtual desktop (and it was even granted regardless of the actual geometry/position) The "unreasonable" focus policies expose an issue about the present linked handling of "allow activation" and "allow raising" (see https://git.reviewboard.kde.org/r/110919/ ) Activation would match "extreme" (if the window maps on the same virtual desktop, half a mile away from the mouse, it won't receive the focus) but not regarding raising (which is actually an issue entirely different from FSP) REVIEW: 112585 CCBUG: 80897 --- manage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manage.cpp b/manage.cpp index c4206d2d9b..e1e8ae5409 100644 --- a/manage.cpp +++ b/manage.cpp @@ -569,7 +569,7 @@ bool Client::manage(xcb_window_t w, bool isMapped) } } else if (allow) { // also force if activation is allowed - if (!isOnCurrentDesktop()) { + if (!isOnCurrentDesktop() && options->focusPolicyIsReasonable()) { VirtualDesktopManager::self()->setCurrent(desktop()); } /*if (!isOnCurrentActivity()) {