yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

scenes/opengl: Use std::array to store lanczos kernel data

Browse source 
This fixes a compiler warning (-Wclass-memaccess) and makes code a bit
cleaner.
This commit is contained in:
Vlad Zahorodnii 2020-09-09 16:42:53 +03:00
parent e14a011165
commit 53cb4207ea
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins/scenes/opengl/lanczosfilter.cpp
View file

@ -151,7 +151,7 @@ void LanczosFilter::createKernel(float delta, int *size)
values[i] = val;
}
memset(m_kernel, 0, 16 * sizeof(QVector4D));
m_kernel.fill(QVector4D());
// Normalize the kernel
for (int i = 0; i < kernelSize; i++) {
@ -164,7 +164,7 @@ void LanczosFilter::createKernel(float delta, int *size)
void LanczosFilter::createOffsets(int count, float width, Qt::Orientation direction)
{
memset(m_offsets, 0, 16 * sizeof(QVector2D));
m_offsets.fill(QVector2D());
for (int i = 0; i < count; i++) {
m_offsets[i] = (direction == Qt::Horizontal) ?
QVector2D(i / width, 0) : QVector2D(0, i / width);
@ -406,8 +406,8 @@ void LanczosFilter::discardCacheTexture(EffectWindow *w)
void LanczosFilter::setUniforms()
{
glUniform2fv(m_uOffsets, 16, (const GLfloat*)m_offsets);
glUniform4fv(m_uKernel, 16, (const GLfloat*)m_kernel);
glUniform2fv(m_uOffsets, m_offsets.size(), (const GLfloat*)m_offsets.data());
glUniform4fv(m_uKernel, m_kernel.size(), (const GLfloat*)m_kernel.data());
}
} // namespace

4
plugins/scenes/opengl/lanczosfilter.h
View file

@ -54,8 +54,8 @@ private:
QScopedPointer<GLShader> m_shader;
int m_uOffsets;
int m_uKernel;
QVector2D m_offsets[16];
QVector4D m_kernel[16];
std::array<QVector2D, 16> m_offsets;
std::array<QVector4D, 16> m_kernel;
Scene *m_scene;
};