yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix crash in debug console

Browse source 
We need an explicit return type; otherwise a QStringBuilder object will
be returned, which can reference already destroyed strings.
This commit is contained in:
Vlad Zahorodnii 2021-04-23 13:23:57 +03:00 committed by Aleix Pol Gonzalez
parent b372de8c74
commit 55c95f685f
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/debug_console.cpp
View file

@ -1194,10 +1194,14 @@ QVariant DebugConsoleModel::data(const QModelIndex &index, int role) const
return QVariant();
}
auto generic = [] (AbstractClient* c) { return c->caption() + QLatin1Char(' ') + QString::fromUtf8(c->metaObject()->className()); };
auto generic = [] (AbstractClient *c) -> QString {
return c->caption() + QLatin1Char(' ') + QString::fromUtf8(c->metaObject()->className());
};
switch (index.parent().internalId()) {
case s_x11ClientId:
return clientData<X11Client>(index, role, m_x11Clients, [] (X11Client* c) { return QStringLiteral("0x%1: %2").arg(c->window(), 0, 16).arg(c->caption()); });
return clientData<X11Client>(index, role, m_x11Clients, [](X11Client *c) -> QString {
return QStringLiteral("0x%1: %2").arg(c->window(), 0, 16).arg(c->caption());
});
case s_x11UnmanagedId: {
if (index.row() >= m_unmanageds.count()) {
return QVariant();