From 55d3f2933f3735958dfa0f99e6d28e02cd083576 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Mon, 18 Feb 2019 14:58:30 +0200 Subject: [PATCH] [effects/desktopgrid] Don't copy windows on X11 Summary: Currently, the Desktop Grid effect tries to copy a client when user moves it. But on X11 such behavior doesn't make sense because a client can't be on multiple desktops (except on all). BUG: 404442 FIXED-IN: 5.15.1 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19116 --- effects/desktopgrid/desktopgrid.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/effects/desktopgrid/desktopgrid.cpp b/effects/desktopgrid/desktopgrid.cpp index d920bea931..0709974cb4 100644 --- a/effects/desktopgrid/desktopgrid.cpp +++ b/effects/desktopgrid/desktopgrid.cpp @@ -517,7 +517,7 @@ void DesktopGridEffect::windowInputMouseEvent(QEvent* e) effects->moveWindow(windowMove, unscalePos(me->pos(), NULL) + windowMoveDiff, true, 1.0 / scale[screen]); } if (wasWindowMove) { - if (!effects->waylandDisplay() || (me->modifiers() & Qt::ControlModifier)) { + if (effects->waylandDisplay() && (me->modifiers() & Qt::ControlModifier)) { wasWindowCopy = true; effects->defineCursor(Qt::DragCopyCursor); } else {