yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects: Fix initial hidden state: also initially hide windows from other desktops

Browse source 
This fixes the case in Show All Windows (F10) and Show Windows of
Current App (F7): non-minimized windows from other desktops suddenly
pop-up at the start of these effects instead of remaining hidden.

Note: don't test this with full-screen/maximized windows open on current
desktop otherwise you probably won't see any difference.
This commit is contained in:
ivan tkachenko 2022-08-04 15:21:45 +03:00
parent 73fa0d124f
commit 56530ce939
No known key found for this signature in database
GPG key ID: AF72731B7C654CB3
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/effects/private/qml/WindowHeapDelegate.qml
View file

@ -20,7 +20,8 @@ Item {
required property Item windowHeap
readonly property bool selected: windowHeap.selectedIndex === index
//TODO: move?
readonly property bool initialHidden: client.minimized || client.desktop !== KWinComponents.Workspace.currentDesktop
readonly property bool hidden: {
if (windowHeap.showOnly === "activeClass") {
// client.resourceName is not an actual String as comes from a QByteArray so === would fail
@ -66,7 +67,7 @@ Item {
if (windowHeap.effectiveOrganized) {
return hidden ? "active-hidden" : "active";
}
return client.minimized ? "initial-minimized" : "initial";
return initialHidden ? "initial-hidden" : "initial";
}
visible: opacity > 0
@ -215,7 +216,7 @@ Item {
y: (thumb.client.y - targetScreen.geometry.y - (thumb.windowHeap.absolutePositioning ? windowHeap.layout.Kirigami.ScenePosition.y : 0)) * (1 - effect.partialActivationFactor) + cell.y * effect.partialActivationFactor
width: thumb.client.width * (1 - effect.partialActivationFactor) + cell.width * effect.partialActivationFactor
height: thumb.client.height * (1 - effect.partialActivationFactor) + cell.height * effect.partialActivationFactor
opacity: thumb.client.minimized || thumb.client.desktop !== KWinComponents.Workspace.currentDesktop ? effect.partialActivationFactor : 1
opacity: thumb.initialHidden ? effect.partialActivationFactor : 1
}
PropertyChanges {
target: icon
@ -227,7 +228,7 @@ Item {
}
},
State {
name: "initial-minimized"
name: "initial-hidden"
extend: "initial"
PropertyChanges {
target: thumb
@ -271,7 +272,7 @@ Item {
]
transitions: Transition {
to: "initial, initial-minimized, active, active-hidden"
to: "initial, initial-hidden, active, active-hidden"
enabled: thumb.windowHeap.animationEnabled
NumberAnimation {
duration: thumb.windowHeap.animationDuration