yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: don't log addFB failure for direct scanout

Browse source 
It can spam the log and isn't really useful

BUG: 449556
FIXED-IN: 5.24
This commit is contained in:
Xaver Hugl 2022-02-05 15:28:01 +01:00
parent 6a0430eaa0
commit 569a994644
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/backends/drm/drm_buffer_gbm.cpp
View file

@ -148,17 +148,21 @@ void DrmGbmBuffer::initialize()
if (modifiers[0] != DRM_FORMAT_MOD_INVALID && m_gpu->addFB2ModifiersSupported()) {
if (drmModeAddFB2WithModifiers(m_gpu->fd(), m_size.width(), m_size.height(), m_format, handles, strides, offsets, modifiers, &m_bufferId, DRM_MODE_FB_MODIFIERS)) {
gbm_format_name_desc name;
gbm_format_get_name(m_format, &name);
qCCritical(KWIN_DRM) << "drmModeAddFB2WithModifiers on GPU" << m_gpu->devNode() << "failed for a buffer with format" << name.name << "and modifier" << modifiers[0] << strerror(errno);
if (m_surface) {
gbm_format_name_desc name;
gbm_format_get_name(m_format, &name);
qCCritical(KWIN_DRM) << "drmModeAddFB2WithModifiers on GPU" << m_gpu->devNode() << "failed for a buffer with format" << name.name << "and modifier" << modifiers[0] << strerror(errno);
}
}
} else {
if (drmModeAddFB2(m_gpu->fd(), m_size.width(), m_size.height(), m_format, handles, strides, offsets, &m_bufferId, 0)) {
// fallback
if (drmModeAddFB(m_gpu->fd(), m_size.width(), m_size.height(), 24, 32, strides[0], handles[0], &m_bufferId) != 0) {
gbm_format_name_desc name;
gbm_format_get_name(m_format, &name);
qCCritical(KWIN_DRM) << "drmModeAddFB2 and drmModeAddFB both failed on GPU" << m_gpu->devNode() << "for a buffer with format" << name.name << "and modifier" << modifiers[0] << strerror(errno);
if (m_surface) {
gbm_format_name_desc name;
gbm_format_get_name(m_format, &name);
qCCritical(KWIN_DRM) << "drmModeAddFB2 and drmModeAddFB both failed on GPU" << m_gpu->devNode() << "for a buffer with format" << name.name << "and modifier" << modifiers[0] << strerror(errno);
}
}
}
}