From 58916aac4e157aa39ea71122a67a7c4db3b83876 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Sat, 31 Dec 2022 13:55:29 +0200 Subject: [PATCH] tabbox: Remove Xcb::sync() TabBox::hide() used to contain the following code QApplication::syncX(); XEvent otherEvent; while (XCheckTypedEvent(display(), EnterNotify, &otherEvent)) ; The purpose of XSync() is to flush any pending requests and wait until the X server processes them. After that, we can go through event queue to find relevant events. Why did tabbox go through the event queue to find the EnterNotify events? It's unclear. So it was removed in b4c957b617253307e3418e4358c2bab5595d9724. However, the XSync() call was left out. It doesn't make sense on its own. So remove it too. --- src/tabbox/tabbox.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tabbox/tabbox.cpp b/src/tabbox/tabbox.cpp index c363f2d768..9f0d879124 100644 --- a/src/tabbox/tabbox.cpp +++ b/src/tabbox/tabbox.cpp @@ -725,9 +725,6 @@ void TabBox::hide(bool abort) qCDebug(KWIN_TABBOX) << "Tab box was not properly closed by an effect"; } m_tabBox->hide(abort); - if (kwinApp()->x11Connection()) { - Xcb::sync(); - } } void TabBox::reconfigure()