yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid unnecessary Workspace::updateClientArea()

Browse source 
Currently, when a window is added or removed, the work area will be
recomputed unconditionally. But in many cases, it's unnecessary because
only a small fraction of windows has a strut (in default setup, only the
panel has a strut).
This commit is contained in:
Vlad Zahorodnii 2023-06-02 18:48:57 +03:00
parent 30ac125986
commit 59cea67401
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/workspace.cpp
View file

@ -706,7 +706,9 @@ void Workspace::addX11Window(X11Window *window)
Q_ASSERT(!m_windows.contains(window));
m_windows.append(window);
addToStack(window);
updateClientArea(); // This cannot be in manage(), because the window got added only now
if (window->hasStrut()) {
updateClientArea(); // This cannot be in manage(), because the window got added only now
}
window->updateLayer();
if (window->isDesktop()) {
raiseWindow(window);
@ -798,7 +800,9 @@ void Workspace::addWaylandWindow(Window *window)
addToStack(window);
updateStackingOrder(true);
updateClientArea();
if (window->hasStrut()) {
updateClientArea();
}
if (window->wantsInput() && !window->isMinimized()) {
activateWindow(window);
}
@ -840,11 +844,13 @@ void Workspace::removeWindow(Window *window)
window->setShortcut(QString()); // Remove from client_keys
windowShortcutUpdated(window); // Needed, since this is otherwise delayed by setShortcut() and wouldn't run
}
if (window->hasStrut()) {
updateClientArea();
}
Q_EMIT windowRemoved(window);
updateStackingOrder(true);
updateClientArea();
updateTabbox();
}
@ -2021,8 +2027,6 @@ void Workspace::addInternalWindow(InternalWindow *window)
}
updateStackingOrder(true);
updateClientArea();
Q_EMIT windowAdded(window);
}
@ -2031,8 +2035,6 @@ void Workspace::removeInternalWindow(InternalWindow *window)
m_windows.removeOne(window);
updateStackingOrder();
updateClientArea();
Q_EMIT windowRemoved(window);
}