yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compress MotionNotify events while user moving/resizing, this should

Browse source 
make opaque resizing acceptable again, close #67471, and stop people
complaining.

svn path=/trunk/kdebase/kwin/; revision=269302
This commit is contained in:
Luboš Luňák 2003-11-24 14:38:03 +00:00
parent 0cf7454675
commit 5bbec2c584
1 changed files with 51 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
events.cpp
View file

@ -25,6 +25,7 @@ License. See the file "COPYING" for the exact licensing terms.
#include <qapplication.h> #include <qapplication.h>
#include <X11/extensions/shape.h> #include <X11/extensions/shape.h>
#include <X11/Xatom.h>
extern Time qt_x_time; extern Time qt_x_time;
extern Atom qt_window_role; extern Atom qt_window_role;
@ -1174,6 +1175,54 @@ bool Client::buttonReleaseEvent( Window w, int /*button*/, int state, int x, int
return true; return true;
} }
static bool was_motion = false;
static bool motion_done = false;
// check whole incoming X queue for MotionNotify events
// checking whole queue is done by always returning False in the predicate
// if there's another motion event in the queue, and there's no other relevant
// event before it, the current motion event may be safely discarded
// this helps avoiding being overloaded by being flooded from many events
// from the XServer
static Bool motion_predicate( Display*, XEvent* ev, XPointer )
{
if( motion_done )
return False;
if( ev->type == MotionNotify )
{
was_motion = true;
motion_done = true;
}
else if( ev->type == ConfigureNotify // irrelevant often occuring events
|| ev->type == Expose )
; // ignore
else if( ev->type == PropertyNotify )
{
if( ev->xproperty.atom == XA_WM_NORMAL_HINTS
&& QWidget::find( ev->xproperty.window ))
; // ignore - Qt is causing this in QWidget::internalSetGeometry()
else
{
was_motion = false;
motion_done = true;
}
}
else
{
was_motion = false;
motion_done = true;
}
return False;
}
static bool waitingMotionEvent()
{
was_motion = false;
motion_done = false;
XEvent dummy;
XCheckIfEvent( qt_xdisplay(), &dummy, motion_predicate, NULL );
return was_motion;
}
// return value matters only when filtering events before decoration gets them // return value matters only when filtering events before decoration gets them
bool Client::motionNotifyEvent( Window w, int /*state*/, int x, int y, int x_root, int y_root ) bool Client::motionNotifyEvent( Window w, int /*state*/, int x, int y, int x_root, int y_root )
{ {
@ -1188,7 +1237,8 @@ bool Client::motionNotifyEvent( Window w, int /*state*/, int x, int y, int x_roo
return false; return false;
} }
handleMoveResize( x, y, x_root, y_root ); if( !waitingMotionEvent())
handleMoveResize( x, y, x_root, y_root );
return true; return true;
} }